Re: [RFC PATCH v1 11/30] fs: new API for handling i_version

2017-03-03 Thread Jeff Layton
On Sat, 2017-03-04 at 10:55 +1100, NeilBrown wrote: > On Wed, Dec 21 2016, Jeff Layton wrote: > > > We already have inode_inc_iversion. Add inode_set_iversion, > > inode_get_iversion, inode_cmp_iversion and inode_iversion_need_inc. > > This list of added interfaces is incomplete. > And some of th

Re: [RFC PATCH v1 11/30] fs: new API for handling i_version

2017-03-03 Thread Jeff Layton
On Fri, 2017-03-03 at 17:36 -0500, J. Bruce Fields wrote: > The patch ordering is a little annoying as I'd like to be able to be > able to verify the implementation at the same time these new interfaces > are added, but, I don't know, I don't have a better idea. > Fair point. My thinking was "add

Re: [RFC PATCH v1 11/30] fs: new API for handling i_version

2017-03-03 Thread NeilBrown
On Wed, Dec 21 2016, Jeff Layton wrote: > We already have inode_inc_iversion. Add inode_set_iversion, > inode_get_iversion, inode_cmp_iversion and inode_iversion_need_inc. This list of added interfaces is incomplete. And some of these interfaces could really use some justification up front. You

Re: [RFC PATCH v1 11/30] fs: new API for handling i_version

2017-03-03 Thread J. Bruce Fields
The patch ordering is a little annoying as I'd like to be able to be able to verify the implementation at the same time these new interfaces are added, but, I don't know, I don't have a better idea. Anyway, various nits: On Wed, Dec 21, 2016 at 12:03:28PM -0500, Jeff Layton wrote: > We already ha

[RFC PATCH v1 11/30] fs: new API for handling i_version

2016-12-21 Thread Jeff Layton
We already have inode_inc_iversion. Add inode_set_iversion, inode_get_iversion, inode_cmp_iversion and inode_iversion_need_inc. These should encompass how i_version is currently accessed and manipulated so that we can later change the implementation. Signed-off-by: Jeff Layton --- include/linux