Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-21 Thread Petr Mladek
On Sun 2019-02-17 02:32:22, John Ogness wrote: > Hi Petr, > > I've made changes to the patch that hopefully align with what you are > looking for. I would appreciate it if you could go over it and see if > the changes are in the right direction. And if so, you should decide > whether I should make

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-16 Thread John Ogness
Hi Petr, I've made changes to the patch that hopefully align with what you are looking for. I would appreciate it if you could go over it and see if the changes are in the right direction. And if so, you should decide whether I should make these kinds of changes for the whole series and submit a v

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-15 Thread Petr Mladek
On Fri 2019-02-15 00:36:49, John Ogness wrote: > On 2019-02-14, Petr Mladek wrote: > >> Add the writer functions prb_reserve() and prb_commit(). These make > >> use of processor-reentrant spin locks to limit the number of possible > >> interruption scenarios for the writers. > >> > >> --- a/lib/p

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-14 Thread John Ogness
On 2019-02-15, John Ogness wrote: > prb_commit() does not actually care what is in the handle. It is going > to commit everything up to the reserve. After thinking about what I wrote here, I realized that the struct prb_handle has no purpose in this ringbuffer implementation. We really could simp

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-14 Thread John Ogness
On 2019-02-14, Petr Mladek wrote: >> Add the writer functions prb_reserve() and prb_commit(). These make >> use of processor-reentrant spin locks to limit the number of possible >> interruption scenarios for the writers. >> >> Signed-off-by: John Ogness >> --- >> include/linux/printk_ringbuffer

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-14 Thread Petr Mladek
On Tue 2019-02-12 15:29:42, John Ogness wrote: > Add the writer functions prb_reserve() and prb_commit(). These make > use of processor-reentrant spin locks to limit the number of possible > interruption scenarios for the writers. > > Signed-off-by: John Ogness > --- > include/linux/printk_ringb

[RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-12 Thread John Ogness
Add the writer functions prb_reserve() and prb_commit(). These make use of processor-reentrant spin locks to limit the number of possible interruption scenarios for the writers. Signed-off-by: John Ogness --- include/linux/printk_ringbuffer.h | 17 lib/printk_ringbuffer.c | 172 +