Re: [RFC PATCH nohz] return NOTIFY_BAD in cpu down call back to stop offlining the cpu

2013-05-20 Thread Frederic Weisbecker
2013/5/20 Srivatsa S. Bhat : > On 05/17/2013 02:14 PM, Li Zhong wrote: >> In tick_nohz_cpu_down_callback() if the cpu is the one handling >> timekeeping , it seems that we should return something that could stop >> notify CPU_DOWN_PREPARE, and then start notify CPU_DOWN_FAILED on the >> already cal

Re: [RFC PATCH nohz] return NOTIFY_BAD in cpu down call back to stop offlining the cpu

2013-05-20 Thread Srivatsa S. Bhat
On 05/17/2013 02:14 PM, Li Zhong wrote: > In tick_nohz_cpu_down_callback() if the cpu is the one handling > timekeeping , it seems that we should return something that could stop > notify CPU_DOWN_PREPARE, and then start notify CPU_DOWN_FAILED on the > already called notifier call backs. > > -EINV

[RFC PATCH nohz] return NOTIFY_BAD in cpu down call back to stop offlining the cpu

2013-05-17 Thread Li Zhong
In tick_nohz_cpu_down_callback() if the cpu is the one handling timekeeping , it seems that we should return something that could stop notify CPU_DOWN_PREPARE, and then start notify CPU_DOWN_FAILED on the already called notifier call backs. -EINVAL will be converted to 0 by notifier_to_errno(), th