Re: [RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling

2019-02-20 Thread Michal Kubecek
On Tue, Feb 19, 2019 at 06:27:59PM -0800, Jakub Kicinski wrote: > On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote: > > + else if (is_u32) > > + bitmap_from_arr32(val, bitmap, nbits); > > + else > > + bitmap_copy(val, bitmap, nbi

Re: [RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote: > + else if (is_u32) > + bitmap_from_arr32(val, bitmap, nbits); > + else > + bitmap_copy(val, bitmap, nbits); > + nla_for_each_nested(bit_attr, tb[ETHA_BITSET_

[RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling

2019-02-18 Thread Michal Kubecek
Declare attribute type constants and add helper functions to generate and parse arbitrary length bit sets. Signed-off-by: Michal Kubecek --- Documentation/networking/ethtool-netlink.txt | 63 ++ include/uapi/linux/ethtool_netlink.h | 32 ++ net/ethtool/Makefile