Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Williams, Kenneth
On Fri, Dec 19, 2014 at 08:22:40AM -0800, Roopa Prabhu wrote: > On 12/19/14, 1:55 AM, Jiri Pirko wrote: > >Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: > >>On 19 December 2014 at 14:53, Jiri Pirko wrote: > >>>Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: > >>

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Roopa Prabhu
On 12/19/14, 1:55 AM, Jiri Pirko wrote: Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 14:53, Jiri Pirko wrote: Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 13:57, Jiri Pirko wrote: Fri, Dec 19, 2014 at 06:1

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Andy Gospodarek
On Fri, Dec 19, 2014 at 03:05:27PM +0530, B Viswanath wrote: > On 19 December 2014 at 14:53, Jiri Pirko wrote: > > Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: > >>On 19 December 2014 at 13:57, Jiri Pirko wrote: > >>> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com w

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread B Viswanath
On 19 December 2014 at 15:25, Jiri Pirko wrote: > Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: >>On 19 December 2014 at 14:53, Jiri Pirko wrote: >>> Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 13:57, Jiri Pirko wrote: > Fri,

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 14:53, Jiri Pirko wrote: >> Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: >>>On 19 December 2014 at 13:57, Jiri Pirko wrote: Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com w

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:22:24AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 14:31, B Viswanath wrote: >> On 19 December 2014 at 13:57, Jiri Pirko wrote: >>> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18, Roopa Prabhu wrote: >>

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread B Viswanath
On 19 December 2014 at 14:53, Jiri Pirko wrote: > Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: >>On 19 December 2014 at 13:57, Jiri Pirko wrote: >>> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18, Roopa Prabhu wrote: >>>

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 13:57, Jiri Pirko wrote: >> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >>>On 19 December 2014 at 05:18, Roopa Prabhu wrote: On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: > > >

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread B Viswanath
On 19 December 2014 at 14:31, B Viswanath wrote: > On 19 December 2014 at 13:57, Jiri Pirko wrote: >> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >>>On 19 December 2014 at 05:18, Roopa Prabhu wrote: On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: > > > > We

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread B Viswanath
On 19 December 2014 at 13:57, Jiri Pirko wrote: > Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >>On 19 December 2014 at 05:18, Roopa Prabhu wrote: >>> On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: We also need an interface to set per-switch attributes. Can th

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 05:18, Roopa Prabhu wrote: >> On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: >>> >>> >>> On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: > > On 12/18/

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 12:48:28AM CET, ro...@cumulusnetworks.com wrote: >On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: >> >>On 12/18/2014 3:07 PM, Roopa Prabhu wrote: >>>On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: >On 12/18/14, 10:02 AM, Varlese,

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
opa Prabhu; Varlese, Marco >>Cc: net...@vger.kernel.org; Thomas Graf; Jiri Pirko; sfel...@gmail.com; linux- >>ker...@vger.kernel.org >>Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port >>configuration >> >>On 12/18/2014 10:14 AM, Roopa Prabhu wrote: &

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread B Viswanath
On 19 December 2014 at 05:18, Roopa Prabhu wrote: > On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: >> >> >> On 12/18/2014 3:07 PM, Roopa Prabhu wrote: >>> >>> On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: > > On 12/18/14, 10:02 AM, Varl

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Thomas Graf
On 12/18/14 at 06:02pm, Varlese, Marco wrote: > Roopa, one of the comments I got from Thomas Graf on my v1 patch was that > your patch and mine were supplementary ("I think Roopa's patches are > supplementary. Not all switchdev users will be backed with a Linux Bridge. I > therefore welcome your

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch Por

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Samudrala, Sridhar
On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch Port Attributes section */ + +enum { +IFLA_ATTR_

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch Port Attributes section */ + +enum { +IFLA_ATTR_UNSPEC, +IFLA_ATTR_LEARNING, Any reason

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Arad, Ronen
l.com; linux- >ker...@vger.kernel.org >Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port >configuration > >On 12/18/2014 10:14 AM, Roopa Prabhu wrote: >> On 12/18/14, 10:02 AM, Varlese, Marco wrote: >>> Removed unnecessary content for ease of reading...

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread John Fastabend
On 12/18/2014 10:14 AM, Roopa Prabhu wrote: > On 12/18/14, 10:02 AM, Varlese, Marco wrote: >> Removed unnecessary content for ease of reading... >> +/* Switch Port Attributes section */ + +enum { +IFLA_ATTR_UNSPEC, +IFLA_ATTR_LEARNING, >>> An

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch Port Attributes section */ + +enum { + IFLA_ATTR_UNSPEC, + IFLA_ATTR_LEARNING, Any reason you want learning here ?. This is covered as part of the bridge setlink attributes.

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Varlese, Marco
Removed unnecessary content for ease of reading... > > +/* Switch Port Attributes section */ > > + > > +enum { > > + IFLA_ATTR_UNSPEC, > > + IFLA_ATTR_LEARNING, > Any reason you want learning here ?. This is covered as part of > the bridge setlink attribu

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
Pirko; sfel...@gmail.com; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration On 12/18/14, 6:55 AM, Varlese, Marco wrote: -Original Message- From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] Sent: Thursday, December 18, 2014

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Varlese, Marco
l...@gmail.com; linux-kernel@vger.kernel.org > Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port > configuration > > On 12/18/14, 6:55 AM, Varlese, Marco wrote: > >> -Original Message- > >> From: Roopa Prabhu [mailto:ro...@cumulusnetworks.

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Arad, Ronen
Varlese, Marco > >> Sent: Thursday, December 18, 2014 4:56 PM > >> To: Roopa Prabhu > >> Cc: net...@vger.kernel.org; Fastabend, John R; Thomas Graf; Jiri > >> Pirko; sfel...@gmail.com; linux-kernel@vger.kernel.org > >> Subject: RE: [RFC PATCH net-next v2 1

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread John Fastabend
c: net...@vger.kernel.org; Fastabend, John R; Thomas Graf; Jiri Pirko; >> sfel...@gmail.com; linux-kernel@vger.kernel.org >> Subject: RE: [RFC PATCH net-next v2 1/1] net: Support for switch port >> configuration >> >>> -Original Message- >>> From: R

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Arad, Ronen
gt; sfel...@gmail.com; linux-kernel@vger.kernel.org > Subject: RE: [RFC PATCH net-next v2 1/1] net: Support for switch port > configuration > > > -Original Message- > > From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > > Sent: Thursday, December 18,

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Varlese, Marco
.com; linux- > ker...@vger.kernel.org > Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port > configuration > > On 12/18/14 at 11:29am, Varlese, Marco wrote: > > diff --git a/include/uapi/linux/if_link.h > > b/include/uapi/linux/if_link.h index f7d0d2d..19cb51a

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
@vger.kernel.org Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration On 12/18/14, 3:29 AM, Varlese, Marco wrote: From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch

RE: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Varlese, Marco
gt; Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port > configuration > > On 12/18/14, 3:29 AM, Varlese, Marco wrote: > > From: Marco Varlese > > > > Switch hardware offers a list of attributes that are configurable on a > > per port basis. > &g

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 3:29 AM, Varlese, Marco wrote: From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific values to specific attributes. There will be a s

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Thomas Graf
On 12/18/14 at 11:29am, Varlese, Marco wrote: > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index f7d0d2d..19cb51a 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -146,6 +146,7 @@ enum { > IFLA_PHYS_PORT_ID, > IFLA_CAR

[RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Varlese, Marco
From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific values to specific attributes. There will be a separate patch that adds the "get" functionalit