Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Paul E. McKenney
On Tue, Apr 18, 2017 at 05:20:38PM +0200, Johannes Berg wrote: > On Tue, 2017-04-18 at 08:17 -0700, Paul E. McKenney wrote: > > > > Again, no (S)RCU abuse here, just an ABBA deadlock. > > > > OK, please accept my apologies for failing to follow the thread. > > No worries - just wanted to clarify

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Johannes Berg
On Tue, 2017-04-18 at 08:17 -0700, Paul E. McKenney wrote: > > Again, no (S)RCU abuse here, just an ABBA deadlock. > > OK, please accept my apologies for failing to follow the thread. No worries - just wanted to clarify this in case I was missing something. > I nevertheless reiterate my advice

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Paul E. McKenney
On Tue, Apr 18, 2017 at 03:40:32PM +0200, Johannes Berg wrote: > On Tue, 2017-04-18 at 06:31 -0700, Paul E. McKenney wrote: > > On Tue, Apr 18, 2017 at 11:39:27AM +0200, Johannes Berg wrote: > > > On Mon, 2017-04-17 at 09:01 -0700, Paul E. McKenney wrote: > > > > > > > If you have not already done

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Johannes Berg
On Tue, 2017-04-18 at 06:31 -0700, Paul E. McKenney wrote: > On Tue, Apr 18, 2017 at 11:39:27AM +0200, Johannes Berg wrote: > > On Mon, 2017-04-17 at 09:01 -0700, Paul E. McKenney wrote: > > > > > If you have not already done so, please run this with debug > > > enabled, > > > especially CONFIG_PR

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Paul E. McKenney
On Tue, Apr 18, 2017 at 11:39:27AM +0200, Johannes Berg wrote: > On Mon, 2017-04-17 at 09:01 -0700, Paul E. McKenney wrote: > > > If you have not already done so, please run this with debug enabled, > > especially CONFIG_PROVE_LOCKING=y (which implies CONFIG_PROVE_RCU=y). > > This is important bec

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-18 Thread Johannes Berg
On Mon, 2017-04-17 at 09:01 -0700, Paul E. McKenney wrote: > If you have not already done so, please run this with debug enabled, > especially CONFIG_PROVE_LOCKING=y (which implies CONFIG_PROVE_RCU=y). > This is important because there are configurations for which the > deadlocks you saw with SRCU

Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-17 Thread Paul E. McKenney
On Sun, Apr 16, 2017 at 11:51:37AM +0200, Nicolai Stange wrote: > Currently, a dentry's debugfs_fsdata instance is allocated from > debugfs_file_get() at first usage, i.e. at first file opening. > > It won't ever get freed though. > > Ideally, these instances would get freed after the last open f

[RFC PATCH 9/9] debugfs: free debugfs_fsdata instances

2017-04-16 Thread Nicolai Stange
Currently, a dentry's debugfs_fsdata instance is allocated from debugfs_file_get() at first usage, i.e. at first file opening. It won't ever get freed though. Ideally, these instances would get freed after the last open file handle gets closed again, that is from the fops' ->release(). Unfortuna