Re: [RFC PATCH 7/8] KVM: i8254: Remove need for irq ack notifier

2019-02-06 Thread Julian Stecklina
Paolo Bonzini writes: > Alternatively, it is probably a good time to switch the default to split > irqchip > in QEMU. Split irqchip was introduced in kernel 4.5, which was released about > three years ago. I totally agree. At some point, the in-kernel PIT/PIC emulation should also be removed,

Re: [RFC PATCH 7/8] KVM: i8254: Remove need for irq ack notifier

2019-02-06 Thread Paolo Bonzini
On 04/02/19 15:42, Suthikulpanit, Suravee wrote: > From: Julian Stecklina > > ACK notifiers don't work with AMD AVIC when the PIT interrupt is > delivered as edge-triggered fixed interrupt via the IOAPIC. AMD > processors cannot exit on EOI for these interrupts. The ACK notifiers do > work when t

[RFC PATCH 7/8] KVM: i8254: Remove need for irq ack notifier

2019-02-04 Thread Suthikulpanit, Suravee
From: Julian Stecklina ACK notifiers don't work with AMD AVIC when the PIT interrupt is delivered as edge-triggered fixed interrupt via the IOAPIC. AMD processors cannot exit on EOI for these interrupts. The ACK notifiers do work when the interrupt is delivered via PIC as ExtINT, because the ACK