Re: [RFC PATCH 7/7] rslib: Fix remaining decoder flaws

2019-06-20 Thread Ferdinand Blomqvist
Hi, On 2019-06-17 23:00:27, Thomas Gleixner wrote: On Sat, 30 Mar 2019, Ferdinand Blomqvist wrote: The decoder is flawed in the following ways: ... Aside of the fact that I had to wrap my brain around this crime I committed more than a decade ago, all of this was really a pleasure to review.

Re: [RFC PATCH 7/7] rslib: Fix remaining decoder flaws

2019-06-17 Thread Thomas Gleixner
On Sat, 30 Mar 2019, Ferdinand Blomqvist wrote: > The decoder is flawed in the following ways: ... > - Also fix errors in parity when correcting in-place. Another option > would be to completely disregard errors in the parity, but then the > interface makes it impossible to write tests that t

[RFC PATCH 7/7] rslib: Fix remaining decoder flaws

2019-03-30 Thread Ferdinand Blomqvist
The decoder is flawed in the following ways: - The decoder sometimes fails silently, i.e. it announces success but returns a word that is not a codeword. - The return value of the decoder is incoherent with respect to how fixed erasures are counted. If the word to be decoded is a codeword,