On Fri, May 15, 2020 at 12:06 AM Jeffrey Hugo wrote:
> >> + u16 req_id;
> >> + u8 seq_id;
> >> + u8 cmd;
> >> + u32 resv;
> >> + u64 src_addr;
> >> + u64 dest_addr;
> >> + u32 len;
> >> + u32 resv2;
> >> + u64
Thanks for the review.
On 5/14/2020 3:36 PM, Arnd Bergmann wrote:
On Thu, May 14, 2020 at 4:09 PM Jeffrey Hugo wrote:
+struct dbc_req { /* everything must be little endian encoded */
Instead of the comment, I suppose you want to use __le16 and __le32
types and let sparse check that you got
On Thu, May 14, 2020 at 4:09 PM Jeffrey Hugo wrote:
>
> +struct dbc_req { /* everything must be little endian encoded */
Instead of the comment, I suppose you want to use __le16 and __le32
types and let sparse check that you got it right.
> + u16 req_id;
> + u8 seq_id;
> +
On 5/14/2020 10:37 AM, Greg KH wrote:
On Thu, May 14, 2020 at 10:12:03AM -0600, Jeffrey Hugo wrote:
On 5/14/2020 9:56 AM, Greg KH wrote:
On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote:
On 5/14/2020 8:14 AM, Greg KH wrote:
On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wr
On Thu, May 14, 2020 at 10:12:03AM -0600, Jeffrey Hugo wrote:
> On 5/14/2020 9:56 AM, Greg KH wrote:
> > On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote:
> > > On 5/14/2020 8:14 AM, Greg KH wrote:
> > > > On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
> > > > > +struct q
On 5/14/2020 9:56 AM, Greg KH wrote:
On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote:
On 5/14/2020 8:14 AM, Greg KH wrote:
On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
+struct qaic_execute {
+ __u16 ver;/* struct version, must be 1 */
No need
On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote:
> On 5/14/2020 8:14 AM, Greg KH wrote:
> > On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
> > > +struct qaic_execute {
> > > + __u16 ver;/* struct version, must be 1 */
> >
> > No need for structures to be v
On 5/14/2020 8:14 AM, Greg KH wrote:
On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
+struct qaic_execute {
+ __u16 ver;/* struct version, must be 1 */
No need for structures to be versioned. If you change something, then
add a new ioctl if you really needed
On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
> +struct qaic_execute {
> + __u16 ver;/* struct version, must be 1 */
No need for structures to be versioned. If you change something, then
add a new ioctl if you really needed it.
thanks,
greg k-h
Once a user has configured the device via the control path for their
workload, the user may use the data path to execute the workload. Using
the data path involves several steps.
First, the user must use the memory ioctl to allocate one or more buffers
for use by the workload. These buffers hold
10 matches
Mail list logo
