Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 04:09:53PM -0800, Alexander Duyck wrote: > On Mon, 2019-02-11 at 17:52 -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 11, 2019 at 01:00:53PM -0800, Alexander Duyck wrote: > > > On Mon, 2019-02-11 at 14:54 -0500, Michael S. Tsirkin wrote: > > > > On Mon, Feb 11, 2019 at 10:

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 01:00:53PM -0800, Alexander Duyck wrote: > On Mon, 2019-02-11 at 14:54 -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 11, 2019 at 10:10:06AM -0800, Alexander Duyck wrote: > > > On Mon, 2019-02-11 at 12:36 -0500, Michael S. Tsirkin wrote: > > > > On Mon, Feb 11, 2019 at 08:

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Alexander Duyck
On Mon, 2019-02-11 at 14:54 -0500, Michael S. Tsirkin wrote: > On Mon, Feb 11, 2019 at 10:10:06AM -0800, Alexander Duyck wrote: > > On Mon, 2019-02-11 at 12:36 -0500, Michael S. Tsirkin wrote: > > > On Mon, Feb 11, 2019 at 08:31:34AM -0800, Alexander Duyck wrote: > > > > On Sat, 2019-02-09 at 19:49

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 10:19:17AM -0800, Dave Hansen wrote: > On 2/11/19 9:58 AM, Michael S. Tsirkin wrote: > >>> Really it seems we want a virtio ring so we can pass a batch of these. > >>> E.g. 256 entries, 2M each - that's more like it. > >> That only makes sense for a system that's doing high-

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 10:10:06AM -0800, Alexander Duyck wrote: > On Mon, 2019-02-11 at 12:36 -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 11, 2019 at 08:31:34AM -0800, Alexander Duyck wrote: > > > On Sat, 2019-02-09 at 19:49 -0500, Michael S. Tsirkin wrote: > > > > On Mon, Feb 04, 2019 at 10:

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Dave Hansen
On 2/11/19 9:58 AM, Michael S. Tsirkin wrote: >>> Really it seems we want a virtio ring so we can pass a batch of these. >>> E.g. 256 entries, 2M each - that's more like it. >> That only makes sense for a system that's doing high-frequency, >> discontiguous frees of 2M pages. Right now, a 2M free/

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Alexander Duyck
On Mon, 2019-02-11 at 12:36 -0500, Michael S. Tsirkin wrote: > On Mon, Feb 11, 2019 at 08:31:34AM -0800, Alexander Duyck wrote: > > On Sat, 2019-02-09 at 19:49 -0500, Michael S. Tsirkin wrote: > > > On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: > > > > From: Alexander Duyck > >

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 09:48:11AM -0800, Dave Hansen wrote: > On 2/9/19 4:49 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: > >> From: Alexander Duyck > >> > >> Add guest support for providing free memory hints to the KVM hypervisor for > >> fre

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Dave Hansen
On 2/9/19 4:49 PM, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: >> From: Alexander Duyck >> >> Add guest support for providing free memory hints to the KVM hypervisor for >> freed pages huge TLB size or larger. I am restricting the size to >> huge TL

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 08:31:34AM -0800, Alexander Duyck wrote: > On Sat, 2019-02-09 at 19:49 -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > Add guest support for providing free memory hints to the KVM

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-11 Thread Alexander Duyck
On Sat, 2019-02-09 at 19:49 -0500, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Add guest support for providing free memory hints to the KVM hypervisor for > > freed pages huge TLB size or larger. I am restricting t

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-09 Thread Michael S. Tsirkin
On Mon, Feb 04, 2019 at 10:15:52AM -0800, Alexander Duyck wrote: > From: Alexander Duyck > > Add guest support for providing free memory hints to the KVM hypervisor for > freed pages huge TLB size or larger. I am restricting the size to > huge TLB order and larger because the hypercalls are too e

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-08 Thread Alexander Duyck
On Fri, 2019-02-08 at 16:05 -0500, Nitesh Narayan Lal wrote: > On 2/7/19 1:44 PM, Alexander Duyck wrote: > > On Thu, 2019-02-07 at 13:21 -0500, Luiz Capitulino wrote: > > > On Mon, 04 Feb 2019 10:15:52 -0800 > > > Alexander Duyck wrote: > > > > > > > From: Alexander Duyck > > > > > > > > Add gu

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-08 Thread Nitesh Narayan Lal
On 2/7/19 1:44 PM, Alexander Duyck wrote: > On Thu, 2019-02-07 at 13:21 -0500, Luiz Capitulino wrote: >> On Mon, 04 Feb 2019 10:15:52 -0800 >> Alexander Duyck wrote: >> >>> From: Alexander Duyck >>> >>> Add guest support for providing free memory hints to the KVM hypervisor for >>> freed pages h

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-07 Thread Luiz Capitulino
On Thu, 07 Feb 2019 10:44:11 -0800 Alexander Duyck wrote: > On Thu, 2019-02-07 at 13:21 -0500, Luiz Capitulino wrote: > > On Mon, 04 Feb 2019 10:15:52 -0800 > > Alexander Duyck wrote: > > > > > From: Alexander Duyck > > > > > > Add guest support for providing free memory hints to the KVM hy

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-07 Thread Alexander Duyck
On Thu, 2019-02-07 at 13:21 -0500, Luiz Capitulino wrote: > On Mon, 04 Feb 2019 10:15:52 -0800 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Add guest support for providing free memory hints to the KVM hypervisor for > > freed pages huge TLB size or larger. I am restricting the s

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-07 Thread Luiz Capitulino
On Mon, 04 Feb 2019 10:15:52 -0800 Alexander Duyck wrote: > From: Alexander Duyck > > Add guest support for providing free memory hints to the KVM hypervisor for > freed pages huge TLB size or larger. I am restricting the size to > huge TLB order and larger because the hypercalls are too expens

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-05 Thread Alexander Duyck
On Mon, 2019-02-04 at 17:46 -0800, Nadav Amit wrote: > > On Feb 4, 2019, at 4:16 PM, Alexander Duyck > > wrote: > > > > On Mon, Feb 4, 2019 at 4:03 PM Nadav Amit wrote: > > > > On Feb 4, 2019, at 3:37 PM, Alexander Duyck > > > > wrote: > > > > > > > > On Mon, 2019-02-04 at 15:00 -0800, Nadav

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Nadav Amit
> On Feb 4, 2019, at 4:16 PM, Alexander Duyck wrote: > > On Mon, Feb 4, 2019 at 4:03 PM Nadav Amit wrote: >>> On Feb 4, 2019, at 3:37 PM, Alexander Duyck >>> wrote: >>> >>> On Mon, 2019-02-04 at 15:00 -0800, Nadav Amit wrote: > On Feb 4, 2019, at 10:15 AM, Alexander Duyck > wrote: >

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Alexander Duyck
On Mon, Feb 4, 2019 at 4:03 PM Nadav Amit wrote: > > > On Feb 4, 2019, at 3:37 PM, Alexander Duyck > > wrote: > > > > On Mon, 2019-02-04 at 15:00 -0800, Nadav Amit wrote: > >>> On Feb 4, 2019, at 10:15 AM, Alexander Duyck > >>> wrote: > >>> > >>> From: Alexander Duyck > >>> > >>> Add guest su

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Nadav Amit
> On Feb 4, 2019, at 3:37 PM, Alexander Duyck > wrote: > > On Mon, 2019-02-04 at 15:00 -0800, Nadav Amit wrote: >>> On Feb 4, 2019, at 10:15 AM, Alexander Duyck >>> wrote: >>> >>> From: Alexander Duyck >>> >>> Add guest support for providing free memory hints to the KVM hypervisor for >>> f

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Alexander Duyck
On Mon, 2019-02-04 at 15:00 -0800, Nadav Amit wrote: > > On Feb 4, 2019, at 10:15 AM, Alexander Duyck > > wrote: > > > > From: Alexander Duyck > > > > Add guest support for providing free memory hints to the KVM hypervisor for > > freed pages huge TLB size or larger. I am restricting the size

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Nadav Amit
> On Feb 4, 2019, at 10:15 AM, Alexander Duyck > wrote: > > From: Alexander Duyck > > Add guest support for providing free memory hints to the KVM hypervisor for > freed pages huge TLB size or larger. I am restricting the size to > huge TLB order and larger because the hypercalls are too expen

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Alexander Duyck
On Mon, 2019-02-04 at 11:44 -0800, Dave Hansen wrote: > On 2/4/19 10:15 AM, Alexander Duyck wrote: > > +#ifdef CONFIG_KVM_GUEST > > +#include > > +extern struct static_key_false pv_free_page_hint_enabled; > > + > > +#define HAVE_ARCH_FREE_PAGE > > +void __arch_free_page(struct page *page, unsigned

Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Dave Hansen
On 2/4/19 10:15 AM, Alexander Duyck wrote: > +#ifdef CONFIG_KVM_GUEST > +#include > +extern struct static_key_false pv_free_page_hint_enabled; > + > +#define HAVE_ARCH_FREE_PAGE > +void __arch_free_page(struct page *page, unsigned int order); > +static inline void arch_free_page(struct page *page,

[RFC PATCH 3/4] kvm: Add guest side support for free memory hints

2019-02-04 Thread Alexander Duyck
From: Alexander Duyck Add guest support for providing free memory hints to the KVM hypervisor for freed pages huge TLB size or larger. I am restricting the size to huge TLB order and larger because the hypercalls are too expensive to be performing one per 4K page. Using the huge TLB order became