Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-27 Thread William Kucharski
> On Nov 27, 2018, at 9:50 AM, Vlastimil Babka wrote: > > On 11/27/18 3:50 PM, William Kucharski wrote: >> >> I was just double checking that this was meant to be more of a check done >> before code elsewhere performs additional checks and does the actual THP >> mapping, not an all-encompassi

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-27 Thread Vlastimil Babka
On 11/27/18 3:50 PM, William Kucharski wrote: > > I was just double checking that this was meant to be more of a check done > before code elsewhere performs additional checks and does the actual THP > mapping, not an all-encompassing go/no go check for THP mapping. Yes, the code doing the actual

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-27 Thread Michal Hocko
On Tue 27-11-18 07:50:08, William Kucharski wrote: > > > > On Nov 27, 2018, at 6:17 AM, Michal Hocko wrote: > > > > This is only about the process wide flag to disable THP. I do not see > > how this can be alighnement related. I suspect you wanted to ask in the > > smaps patch? > > No, answere

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-27 Thread William Kucharski
> On Nov 27, 2018, at 6:17 AM, Michal Hocko wrote: > > This is only about the process wide flag to disable THP. I do not see > how this can be alighnement related. I suspect you wanted to ask in the > smaps patch? No, answered below. > >> I'm having to deal with both these issues in the tex

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-27 Thread Michal Hocko
On Mon 26-11-18 17:33:32, William Kucharski wrote: > > > This determines whether the page can theoretically be THP-mapped , but > is the intention to also check for proper alignment and/or preexisting > PAGESIZE page cache mappings for the address range? This is only about the process wide flag

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-26 Thread William Kucharski
This determines whether the page can theoretically be THP-mapped , but is the intention to also check for proper alignment and/or preexisting PAGESIZE page cache mappings for the address range? I'm having to deal with both these issues in the text page THP prototype I've been working on for

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-23 Thread Vlastimil Babka
On 11/20/18 11:35 AM, Michal Hocko wrote: > From: Michal Hocko > > David Rientjes has reported that 1860033237d4 ("mm: make > PR_SET_THP_DISABLE immediately active") has changed the way how > we report THPable VMAs to the userspace. Their monitoring tool is > triggering false alarms on PR_SET_THP

Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-20 Thread Michal Hocko
Damn, David somehow didn't make it to the CC list. Sorry about that. On Tue 20-11-18 11:35:15, Michal Hocko wrote: > From: Michal Hocko > > David Rientjes has reported that 1860033237d4 ("mm: make > PR_SET_THP_DISABLE immediately active") has changed the way how > we report THPable VMAs to the u

[RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-20 Thread Michal Hocko
From: Michal Hocko David Rientjes has reported that 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") has changed the way how we report THPable VMAs to the userspace. Their monitoring tool is triggering false alarms on PR_SET_THP_DISABLE tasks because it considers an insufficient TH