Re: [RFC PATCH 3/3] Convert mce_disabled

2012-10-14 Thread Naveen N. Rao
On 10/12/2012 05:26 PM, Borislav Petkov wrote: On Fri, Oct 12, 2012 at 04:20:40PM +0530, Naveen N. Rao wrote: Hi Boris, Thanks for getting to this before I could! Ah ok, I thought you wasn't interested in doing this anymore :). Sorry - just got sidetracked a bit, I'm afraid :) I had a lo

Re: [RFC PATCH 3/3] Convert mce_disabled

2012-10-12 Thread Borislav Petkov
On Fri, Oct 12, 2012 at 05:46:16PM +, Luck, Tony wrote: > > Or, you can modify the mca_config I have there and use bools and pass a > > pointer to each actual bool member in each DEVICE_BIT_ATTR invocation > > (and rename it to DEVICE_BOOL_ATTR). Yeah, that could work, unless I'm > > missing so

RE: [RFC PATCH 3/3] Convert mce_disabled

2012-10-12 Thread Luck, Tony
> Or, you can modify the mca_config I have there and use bools and pass a > pointer to each actual bool member in each DEVICE_BIT_ATTR invocation > (and rename it to DEVICE_BOOL_ATTR). Yeah, that could work, unless I'm > missing something else, of course. This looks like the best solution to me. S

Re: [RFC PATCH 3/3] Convert mce_disabled

2012-10-12 Thread Borislav Petkov
On Fri, Oct 12, 2012 at 04:20:40PM +0530, Naveen N. Rao wrote: > Hi Boris, Thanks for getting to this before I could! Ah ok, I thought you wasn't interested in doing this anymore :). > I had a look but I still feel boolean is a better way to go. With > bool, we can get rid of the #defines above a

Re: [RFC PATCH 3/3] Convert mce_disabled

2012-10-12 Thread Naveen N. Rao
On 10/10/2012 07:50 PM, Borislav Petkov wrote: From: Borislav Petkov Not-Signed-off-by: Borislav Petkov --- arch/x86/include/asm/mce.h | 9 + arch/x86/kernel/cpu/mcheck/mce.c | 12 +--- arch/x86/lguest/boot.c | 2 +- 3 files changed, 11 insertions(+), 12

Re: [RFC PATCH 3/3] Convert mce_disabled

2012-10-10 Thread Borislav Petkov
On Wed, Oct 10, 2012 at 03:46:39PM +, Luck, Tony wrote: > struct mca_config { > - u64 dont_log_ce : 1, > -#define MCA_CFG_DONT_LOG_CE 0 > - __resv1 : 63; > + u64 dont_log_ce : 1, > +#define MCA_CFG_DONT_LOG_CE0 > + mca_disabled: 1, > +#define MCA

RE: [RFC PATCH 3/3] Convert mce_disabled

2012-10-10 Thread Luck, Tony
struct mca_config { - u64 dont_log_ce : 1, -#define MCA_CFG_DONT_LOG_CE0 - __resv1 : 63; + u64 dont_log_ce : 1, +#define MCA_CFG_DONT_LOG_CE 0 + mca_disabled: 1, +#define MCA_CFG_MCA_DISABLED 1 + __resv1 : 62; }; If we

[RFC PATCH 3/3] Convert mce_disabled

2012-10-10 Thread Borislav Petkov
From: Borislav Petkov Not-Signed-off-by: Borislav Petkov --- arch/x86/include/asm/mce.h | 9 + arch/x86/kernel/cpu/mcheck/mce.c | 12 +--- arch/x86/lguest/boot.c | 2 +- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/mce.h