Re: [RFC PATCH 2/6] fs: provide a generic compat_sys_truncate64() implementation

2018-03-18 Thread Kevin Easton
On Sun, Mar 18, 2018 at 05:10:52PM +0100, Dominik Brodowski wrote: > The compat_sys_truncate64() implementations in mips, powerpc, s390, sparc > and x86 only differed based on whether the u64 parameter needed padding > and on its endianness. > ... > +#ifdef __ARCH_WANT_COMPAT_SYS_TRUNCATE64 >

Re: [RFC PATCH 2/6] fs: provide a generic compat_sys_truncate64() implementation

2018-03-18 Thread Linus Torvalds
On Sun, Mar 18, 2018 at 9:10 AM, Dominik Brodowski wrote: > +#ifdef __ARCH_WANT_COMPAT_SYS_TRUNCATE64 > +#if defined(__ARCH_WANT_COMPAT_SYS_WITH_PADDING) && \ > + defined(__ARCH_WANT_LE_COMPAT_SYS) > +COMPAT_SYSCALL_DEFINE4(truncate64, const char __user *, filename, u32 > padding, > +

Re: [RFC PATCH 2/6] fs: provide a generic compat_sys_truncate64() implementation

2018-03-18 Thread Al Viro
On Sun, Mar 18, 2018 at 05:10:52PM +0100, Dominik Brodowski wrote: > +#ifdef __ARCH_WANT_COMPAT_SYS_TRUNCATE64 > +#if defined(__ARCH_WANT_COMPAT_SYS_WITH_PADDING) && \ > + defined(__ARCH_WANT_LE_COMPAT_SYS) > +COMPAT_SYSCALL_DEFINE4(truncate64, const char __user *, filename, u32 > padding, >

[RFC PATCH 2/6] fs: provide a generic compat_sys_truncate64() implementation

2018-03-18 Thread Dominik Brodowski
The compat_sys_truncate64() implementations in mips, powerpc, s390, sparc and x86 only differed based on whether the u64 parameter needed padding and on its endianness. Oh, and some defined the parameters as "unsigned long" which expanded to u64, though it only expected u32 in these parameters. T