Re: [RFC PATCH 2/5] scsi: ufs: Add UFS-feature layer

2020-06-11 Thread Bart Van Assche
On 2020-06-11 19:27, Daejun Park wrote: >>> @@ -2525,6 +2525,8 @@ static int ufshcd_queuecommand(struct Scsi_Host >>> *host, struct scsi_cmnd *cmd) >>> >>>ufshcd_comp_scsi_upiu(hba, lrbp); >>> >>> + ufsf_ops_prep_fn(hba, lrbp); >>> + >>>err = ufshcd_map_sg(hba, lrbp); >>>if (err)

Re: [RFC PATCH 2/5] scsi: ufs: Add UFS-feature layer

2020-06-11 Thread Daejun Park
Hi Bart, On 2020-06-04 18:30, Daejun Park wrote: > > +inline void ufsf_slave_configure(struct ufs_hba *hba, > > + struct scsi_device *sdev) > > +{ > > + /* skip well-known LU */ > > + if (sdev->lun >= UFS_UPIU_MAX_UNIT_NUM_ID) > > +return; > > + > > + if (!(hba->dev_info.b_ufs_featu

Re: [RFC PATCH 2/5] scsi: ufs: Add UFS-feature layer

2020-06-10 Thread Bart Van Assche
On 2020-06-04 18:30, Daejun Park wrote: > This patch is adding UFS feature layer to UFS core driver. > > UFS Driver data structure (struct ufs_hba) > │ > ┌--┐ > │ UFS feature │ <-- HPB module > │layer │ <-- other extended feature module > └--┘ > Each extended

Re: [RFC PATCH 2/5] scsi: ufs: Add UFS-feature layer

2020-06-09 Thread Bart Van Assche
On 2020-06-04 18:30, Daejun Park wrote: > +inline void ufsf_slave_configure(struct ufs_hba *hba, > + struct scsi_device *sdev) > +{ > + /* skip well-known LU */ > + if (sdev->lun >= UFS_UPIU_MAX_UNIT_NUM_ID) > + return; > + > + if (!(hba->dev_inf

[RFC PATCH 2/5] scsi: ufs: Add UFS-feature layer

2020-06-04 Thread Daejun Park
This patch is adding UFS feature layer to UFS core driver. UFS Driver data structure (struct ufs_hba) │ ┌--┐ │ UFS feature │ <-- HPB module │layer │ <-- other extended feature module └--┘ Each extended UFS-Feature module has a bus of ufs-ext feature type. T