Re: [RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-21 Thread Sergey Senozhatsky
On (01/21/14 09:09), Minchan Kim wrote: > On Mon, Jan 20, 2014 at 01:03:48PM +0300, Sergey Senozhatsky wrote: > > On (01/20/14 14:12), Minchan Kim wrote: > > > Hello Sergey, > > > > > > I reviewed this patchset and I suggest somethings. > > > Please have a look and feedback to me. :) > > > > > >

Re: [RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-20 Thread Minchan Kim
On Mon, Jan 20, 2014 at 01:03:48PM +0300, Sergey Senozhatsky wrote: > On (01/20/14 14:12), Minchan Kim wrote: > > Hello Sergey, > > > > I reviewed this patchset and I suggest somethings. > > Please have a look and feedback to me. :) > > > > 1. Let's define new file zram_comp.c > > 2. zram_comp in

Re: [RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-20 Thread Sergey Senozhatsky
On (01/20/14 14:12), Minchan Kim wrote: > Hello Sergey, > > I reviewed this patchset and I suggest somethings. > Please have a look and feedback to me. :) > > 1. Let's define new file zram_comp.c > 2. zram_comp includes following field >.create >.compress >.decompress. >.destroy >

Re: [RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-20 Thread Sergey Senozhatsky
On (01/20/14 14:12), Minchan Kim wrote: > Date: Mon, 20 Jan 2014 14:12:33 +0900 > From: Minchan Kim > To: Sergey Senozhatsky > Cc: Jerome Marchand , Nitin Gupta , > linux-kernel@vger.kernel.org > Subject: Re: [RFC PATCH 2/3] zram: introduce zram compressor operations >

Re: [RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-19 Thread Minchan Kim
Hello Sergey, I reviewed this patchset and I suggest somethings. Please have a look and feedback to me. :) 1. Let's define new file zram_comp.c 2. zram_comp includes following field .create .compress .decompress. .destroy .name 1) create/destroy Will set up necessary things like a

[RFC PATCH 2/3] zram: introduce zram compressor operations struct

2014-01-17 Thread Sergey Senozhatsky
This is preparation patch to add LZ4 compression support. struct zram_compress_ops defines common compress and decompress prototypes. Use these ops->compress and ops->decompress callbacks instead of direct LZO lzo1x_1_compress() and lzo1x_decompress_safe() calls. Compressor ops should be defined