Re: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver

2019-01-09 Thread Eric Biggers
On Mon, Jan 07, 2019 at 08:56:07AM -0800, Eric Biggers wrote: > Hi Kalyani, > > On Mon, Jan 07, 2019 at 02:32:55PM +0530, Kalyani Akula wrote: > > This patch adds SHA3 driver suuport for the Xilinx > > ZynqMP SoC. > > > > Signed-off-by: Kalyani Akula > [...] > > + > > +static struct ahash_alg sh

RE: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver

2019-01-09 Thread Kalyani Akula
t; linux- > cry...@vger.kernel.org; linux-kernel@vger.kernel.org; Kalyani Akula > ; Sarat Chand Savitala > Subject: Re: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver > > On Mon, Jan 07, 2019 at 02:32:55PM +0530, Kalyani Akula wrote: > > This patch adds SHA3 driver suuport for the Xili

Re: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver

2019-01-07 Thread Eric Biggers
Hi Kalyani, On Mon, Jan 07, 2019 at 02:32:55PM +0530, Kalyani Akula wrote: > This patch adds SHA3 driver suuport for the Xilinx > ZynqMP SoC. > > Signed-off-by: Kalyani Akula [...] > + > +static struct ahash_alg sha3_alg = { > + .init = zynqmp_sha_init, > + .update = zy

Re: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver

2019-01-07 Thread Corentin Labbe
On Mon, Jan 07, 2019 at 02:32:55PM +0530, Kalyani Akula wrote: > This patch adds SHA3 driver suuport for the Xilinx > ZynqMP SoC. > > Signed-off-by: Kalyani Akula Hello I have some comment below > +static int zynqmp_sha_init(struct ahash_request *req) > +{ > + const struct zynqmp_eemi_ops

[RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver

2019-01-07 Thread Kalyani Akula
This patch adds SHA3 driver suuport for the Xilinx ZynqMP SoC. Signed-off-by: Kalyani Akula --- drivers/crypto/Kconfig | 10 ++ drivers/crypto/Makefile |1 + drivers/crypto/zynqmp-sha.c | 303 +++ 3 files changed, 314 insertions(+), 0 delet