Re: [RFC PATCH 2/3] Generic Trace Setup and Control (GTSC) code

2007-07-14 Thread Christoph Hellwig
On Fri, Jun 29, 2007 at 10:24:32PM -0500, Tom Zanussi wrote: > The Generic Tracing and Control Interface (GTSC) code. The code looks fine to me from a first look, but the the name is just dumb. Given that all your internal identifiers are trace_* or TRACE_ go all the way and make it CONFIG_TRACE a

Re: [RFC PATCH 2/3] Generic Trace Setup and Control (GTSC) code

2007-07-03 Thread Mathieu Desnoyers
* Tom Zanussi ([EMAIL PROTECTED]) wrote: > The Generic Tracing and Control Interface (GTSC) code. > > Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> > Signed-off-by: David Wilder <[EMAIL PROTECTED]> > --- > include/linux/gtsc.h | 104 + > lib/Kconfig | 10 > lib/Makefile

Re: [RFC PATCH 2/3] Generic Trace Setup and Control (GTSC) code

2007-07-03 Thread Mathieu Desnoyers
Please see comments below, * Tom Zanussi ([EMAIL PROTECTED]) wrote: > The Generic Tracing and Control Interface (GTSC) code. > > Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> > Signed-off-by: David Wilder <[EMAIL PROTECTED]> > --- > include/linux/gtsc.h | 104 + > lib/Kconfig

[RFC PATCH 2/3] Generic Trace Setup and Control (GTSC) code

2007-06-29 Thread Tom Zanussi
The Generic Tracing and Control Interface (GTSC) code. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> Signed-off-by: David Wilder <[EMAIL PROTECTED]> --- include/linux/gtsc.h | 104 + lib/Kconfig | 10 lib/Makefile |2 lib/gtsc.c | 558