Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Sat, Feb 8, 2025 at 12:59 AM Josh Poimboeuf wrote: > > On Fri, Feb 07, 2025 at 11:16:45AM +0800, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > Why does this happen? > > > > It occurs during the KLP transition. It seems like the KLP transition > > is taking

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 9:58 PM Petr Mladek wrote: > > On Thu 2025-02-06 10:35:11, Yafang Shao wrote: > > On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > > > > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > > > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > > > > > > > On

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 5:36 PM Petr Mladek wrote: > > On Fri 2025-02-07 11:16:45, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > > > - Temporary Loss of Patching > > > > > > > > During the repla

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Josh Poimboeuf
On Fri, Feb 07, 2025 at 11:16:45AM +0800, Yafang Shao wrote: > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > Why does this happen? > > It occurs during the KLP transition. It seems like the KLP transition > is taking too long. > > [20329703.332453] livepatch: enabling patch 'livepatc

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Petr Mladek
On Thu 2025-02-06 10:35:11, Yafang Shao wrote: > On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > > > > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: I am not sure if you s

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Petr Mladek
On Fri 2025-02-07 11:16:45, Yafang Shao wrote: > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > > - Temporary Loss of Patching > > > > > > During the replacement process, the old patch is set to a NOP > > > (no-operatio

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-06 Thread Yafang Shao
On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > > However, its current i

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-06 Thread Josh Poimboeuf
On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > The atomic replace livepatch mechanism was introduced to handle scenarios > where we want to unload a specific livepatch without unloading others. > However, its current implementation has significant shortcomings, making > it less than

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-05 Thread Yafang Shao
On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > > > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > > > > > > > O

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-05 Thread Petr Mladek
On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > > > > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > > > > The atomic r

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-04 Thread Yafang Shao
On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > > > The atomic replace livepatch mechanism was introduced to handle > > > >

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-04 Thread Petr Mladek
On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > > The atomic replace livepatch mechanism was introduced to handle scenarios > > > where we want to unload a specific livepatch without unl

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-01-27 Thread Yafang Shao
On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > > However, its current implementation ha

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-01-27 Thread Petr Mladek
On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > The atomic replace livepatch mechanism was introduced to handle scenarios > where we want to unload a specific livepatch without unloading others. > However, its current implementation has significant shortcomings, making > it less than ideal in prac

[RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-01-26 Thread Yafang Shao
The atomic replace livepatch mechanism was introduced to handle scenarios where we want to unload a specific livepatch without unloading others. However, its current implementation has significant shortcomings, making it less than ideal in practice. Below are the key downsides: - It is expensive