Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-13 Thread Ram
On Fri, 2005-07-08 at 12:49, Miklos Szeredi wrote: > > The reason why I implemented that way, is to less confuse the user and > > provide more flexibility. With my implementation, we have the ability > > to share any part of the tree, without bothering if it is a mountpoint > > or not. The side eff

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Miklos Szeredi
> The reason why I implemented that way, is to less confuse the user and > provide more flexibility. With my implementation, we have the ability > to share any part of the tree, without bothering if it is a mountpoint > or not. The side effect of this operation is, it ends up creating > a vfsmount

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Ram
On Fri, 2005-07-08 at 09:51, Miklos Szeredi wrote: > > > > + * recursively change the type of the mountpoint. > > > > + */ > > > > +static int do_change_type(struct nameidata *nd, int flag) > > > > +{ > > > > + struct vfsmount *m, *mnt; > > > > + struct vfspnode *old_pnode = NULL; > > >

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Miklos Szeredi
> > > + * recursively change the type of the mountpoint. > > > + */ > > > +static int do_change_type(struct nameidata *nd, int flag) > > > +{ > > > + struct vfsmount *m, *mnt; > > > + struct vfspnode *old_pnode = NULL; > > > + int err; > > > + > > > + if (!(flag & MS_SHARED) && !(flag & MS_PRIVATE)

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Ram
On Fri, 2005-07-08 at 04:17, Pekka Enberg wrote: > On 7/8/05, Ram <[EMAIL PROTECTED]> wrote: > > This patch adds the shared/private/slave support for VFS trees. > > Inlining the patches to email would be greatly appreciated. Here are > some comments. > > > +int > > +_do_make_mounted(struct nameid

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Ram
On Fri, 2005-07-08 at 07:32, Miklos Szeredi wrote: > > This patch adds the shared/private/slave support for VFS trees. > > [...] > > > -struct vfsmount *lookup_mnt(struct vfsmount *mnt, struct dentry *dentry) > > +struct vfsmount *lookup_mnt(struct vfsmount *mnt, struct dentry *dentry, > > struc

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Miklos Szeredi
> This patch adds the shared/private/slave support for VFS trees. [...] > -struct vfsmount *lookup_mnt(struct vfsmount *mnt, struct dentry *dentry) > +struct vfsmount *lookup_mnt(struct vfsmount *mnt, struct dentry *dentry, > struct dentry *root) > { How about changing it to inline and calling

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Roman Zippel
Hi, On Fri, 8 Jul 2005, Pekka Enberg wrote: > > +#define PNODE_MEMBER_VFS 0x01 > > +#define PNODE_SLAVE_VFS 0x02 > > Enums, please. Is this becoming a requirement now? I personally would rather leave that to personal preference... bye, Roman - To unsubscribe from this list: send the line "

Re: [RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Pekka Enberg
On 7/8/05, Ram <[EMAIL PROTECTED]> wrote: > This patch adds the shared/private/slave support for VFS trees. Inlining the patches to email would be greatly appreciated. Here are some comments. > +int > +_do_make_mounted(struct nameidata *nd, struct vfsmount **mnt) Use two underscores to follow na

[RFC PATCH 1/8] share/private/slave a subtree

2005-07-08 Thread Ram
This patch adds the shared/private/slave support for VFS trees. RP This patch adds the shared/private/slave support for VFS trees. Signed by Ram Pai ([EMAIL PROTECTED]) fs/Makefile|2 fs/dcache.c|2 fs/namei.c |4 fs/namespace.c | 170