Hi Antoine,
> On Oct 26, 2016, at 17:57 , Antoine Tenart
> wrote:
>
> The overlay manager is an in-kernel library helping to handle dt overlay
> loading when using capes.
>
Code related comments
> Signed-off-by: Antoine Tenart
> ---
> drivers/of/Kconfig | 2 +
> d
Hi Antoine,
> On Oct 26, 2016, at 17:57 , Antoine Tenart
> wrote:
>
> The overlay manager is an in-kernel library helping to handle dt overlay
> loading when using capes.
>
All in all a nice idea. Comments inline.
> Signed-off-by: Antoine Tenart
> ---
> drivers/of/Kconfig
On Thu, Oct 27, 2016 at 08:49:29AM -0600, Mathieu Poirier wrote:
>
> I agree - something like this should have attracted more reviews. I
> suggest providing a better explanation, i.e what you are doing and why
> in more details. I reviewed your set and I'm still not sure of
> exactly what it doe
On 27 October 2016 at 08:03, Antoine Tenart
wrote:
> Hello Mathieu,
>
> On Wed, Oct 26, 2016 at 10:29:59AM -0600, Mathieu Poirier wrote:
>>
>> Please find my comments below.
>
> Thanks for the comments. I expected more distant reviews, on the overall
> architecture to know if this could fit the ne
Hello Mathieu,
On Wed, Oct 26, 2016 at 10:29:59AM -0600, Mathieu Poirier wrote:
>
> Please find my comments below.
Thanks for the comments. I expected more distant reviews, on the overall
architecture to know if this could fit the needs of others. But anyway
your comments are helpful if we ever
On 10/26/2016 04:57 PM, Antoine Tenart wrote:
The overlay manager is an in-kernel library helping to handle dt overlay
loading when using capes.
Signed-off-by: Antoine Tenart
---
drivers/of/Kconfig | 2 +
drivers/of/Makefile | 1 +
drive
Hello,
On Wed, 26 Oct 2016 10:29:59 -0600, Mathieu Poirier wrote:
> > + overlay = devm_kzalloc(dev, sizeof(*overlay), GFP_KERNEL);
>
> Function devm_kzalloc() can sleep but you're holding a spinlock - I'm
> surprised the kernel didn't complain here. Allocate the memory before
> holding
Hi Antoine,
Please find my comments below.
On 26 October 2016 at 08:57, Antoine Tenart
wrote:
> The overlay manager is an in-kernel library helping to handle dt overlay
> loading when using capes.
>
> Signed-off-by: Antoine Tenart
> ---
> drivers/of/Kconfig | 2 +
>
The overlay manager is an in-kernel library helping to handle dt overlay
loading when using capes.
Signed-off-by: Antoine Tenart
---
drivers/of/Kconfig | 2 +
drivers/of/Makefile | 1 +
drivers/of/overlay-manager/Kconfig | 6 +
d
9 matches
Mail list logo
