Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-12-01 Thread wangyanan (Y)
On 2020/12/2 2:15, Will Deacon wrote: On Wed, Dec 02, 2020 at 01:19:35AM +0800, wangyanan (Y) wrote: On 2020/12/1 22:16, Will Deacon wrote: On Tue, Dec 01, 2020 at 03:21:23PM +0800, wangyanan (Y) wrote: On 2020/11/30 21:21, Will Deacon wrote: On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan

Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-12-01 Thread Will Deacon
On Wed, Dec 02, 2020 at 01:19:35AM +0800, wangyanan (Y) wrote: > On 2020/12/1 22:16, Will Deacon wrote: > > On Tue, Dec 01, 2020 at 03:21:23PM +0800, wangyanan (Y) wrote: > > > On 2020/11/30 21:21, Will Deacon wrote: > > > > On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan Wang wrote: > > > > > @@ -

Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-12-01 Thread wangyanan (Y)
On 2020/12/1 22:16, Will Deacon wrote: On Tue, Dec 01, 2020 at 03:21:23PM +0800, wangyanan (Y) wrote: On 2020/11/30 21:21, Will Deacon wrote: On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan Wang wrote: diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c index 0271b4a3b9fe

Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-12-01 Thread Will Deacon
On Tue, Dec 01, 2020 at 03:21:23PM +0800, wangyanan (Y) wrote: > On 2020/11/30 21:21, Will Deacon wrote: > > On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan Wang wrote: > > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > > > index 0271b4a3b9fe..696b6aa83faf 100644 > > >

Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-11-30 Thread wangyanan (Y)
Hi Will, On 2020/11/30 21:21, Will Deacon wrote: On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan Wang wrote: When installing a new leaf pte onto an invalid ptep, we need to get_page(ptep). When just updating a valid leaf ptep, we shouldn't get_page(ptep). Incorrect page_count of translation tab

Re: [RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-11-30 Thread Will Deacon
On Mon, Nov 30, 2020 at 08:18:45PM +0800, Yanan Wang wrote: > When installing a new leaf pte onto an invalid ptep, we need to > get_page(ptep). > When just updating a valid leaf ptep, we shouldn't get_page(ptep). > Incorrect page_count of translation tables might lead to memory leak, > when unmapp

[RFC PATCH 1/3] KVM: arm64: Fix possible memory leak in kvm stage2

2020-11-30 Thread Yanan Wang
When installing a new leaf pte onto an invalid ptep, we need to get_page(ptep). When just updating a valid leaf ptep, we shouldn't get_page(ptep). Incorrect page_count of translation tables might lead to memory leak, when unmapping a stage 2 memory range. Signed-off-by: Yanan Wang --- arch/arm64