Re: [RFC PATCH 1/3] ARM64: meson: Add Amlogic Meson GX PM Suspend

2016-11-04 Thread Neil Armstrong
On 11/03/2016 10:53 PM, Sudeep Holla wrote: > > Short response to this patch: NAK > > To be constructive, since this system lacks PSCI system suspend, it just > can't support. Alternatively, this can be normal cpuidle state and you > can use suspend to idle to achieve the same and you need not ha

Re: [RFC PATCH 1/3] ARM64: meson: Add Amlogic Meson GX PM Suspend

2016-11-03 Thread Sudeep Holla
On Thu, Nov 03, 2016 at 03:29:23PM +0100, Neil Armstrong wrote: > The Amlogic Meson GX SoCs uses a non-standard argument to the > PSCI CPU_SUSPEND call to enter system suspend. > > Implement such call within platform_suspend_ops. > > Signed-off-by: Neil Armstrong > --- > drivers/firmware/meson/

Re: [RFC PATCH 1/3] ARM64: meson: Add Amlogic Meson GX PM Suspend

2016-11-03 Thread Mark Rutland
On Thu, Nov 03, 2016 at 03:29:23PM +0100, Neil Armstrong wrote: > The Amlogic Meson GX SoCs uses a non-standard argument to the > PSCI CPU_SUSPEND call to enter system suspend. > > Implement such call within platform_suspend_ops. While I am very much not happy with platform-specific extensions to

[RFC PATCH 1/3] ARM64: meson: Add Amlogic Meson GX PM Suspend

2016-11-03 Thread Neil Armstrong
The Amlogic Meson GX SoCs uses a non-standard argument to the PSCI CPU_SUSPEND call to enter system suspend. Implement such call within platform_suspend_ops. Signed-off-by: Neil Armstrong --- drivers/firmware/meson/Kconfig | 6 +++ drivers/firmware/meson/Makefile | 1 + drivers/fir