Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-09 Thread Masahiro Yamada
2017-10-06 5:58 GMT+09:00 Doug Anderson : > Hi, > > On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada > wrote: >> As far as I tested, I always see only one space after ":=" in v2. >> >> I did not consider this deeply, >> but something is working nicely behind the scene. > > Try adding this to the e

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-05 Thread Doug Anderson
Hi, On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada wrote: > As far as I tested, I always see only one space after ":=" in v2. > > I did not consider this deeply, > but something is working nicely behind the scene. Try adding this to the end of the main Makefile: +$(info LDFLAGS_BUILD_ID = $(L

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-05 Thread Masahiro Yamada
Hi Douglas, 2017-10-05 7:38 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 9:05 PM, Masahiro Yamada > wrote: >> Thanks for the patches. The idea is interesting. >> >> I am not a Chrome developer, but cc-option could be improved somehow. >> >> >> I examined two approaches to mitigate

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-04 Thread Doug Anderson
Hi, On Tue, Oct 3, 2017 at 9:05 PM, Masahiro Yamada wrote: > Thanks for the patches. The idea is interesting. > > I am not a Chrome developer, but cc-option could be improved somehow. > > > I examined two approaches to mitigate the pain. > > [1] Skip cc-option completely when we run non-build ta

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-03 Thread Masahiro Yamada
Hi Douglas, 2017-09-27 2:55 GMT+09:00 Douglas Anderson : > While timing a "no-op" build of the kernel (incrementally building the > kernel even though nothing changed) in the Chrome OS build system I > found that it was much slower than I expected. > > Digging into things a bit, I found that quit

[RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-09-26 Thread Douglas Anderson
While timing a "no-op" build of the kernel (incrementally building the kernel even though nothing changed) in the Chrome OS build system I found that it was much slower than I expected. Digging into things a bit, I found that quite a bit of the time was spent invoking the C compiler even though we