Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-06 Thread Andrew Donnellan
On 06/08/18 15:07, Joe Perches wrote: The multiple line block code can be difficult to read. I 100% agree! My suggestion is to instead write a subroutine to get the commit description and compare that against the returned git commit description. I'll try and do it up more neatly when I've g

Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-05 Thread Joe Perches
On Mon, 2018-08-06 at 13:58 +1000, Andrew Donnellan wrote: > If a patch contains a commit reference that happens to span 3 lines, e.g.: > > === > With the optimizations for TLB invalidation from commit 0cef77c7798a > ("powerpc/64s/radix: flush remote CPUs out of single-threaded > mm_cpumask"), the

[RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-05 Thread Andrew Donnellan
If a patch contains a commit reference that happens to span 3 lines, e.g.: === With the optimizations for TLB invalidation from commit 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask"), the scope of a TLBI (global vs. local) can now be influenced by the value