Re: [RFC PATCH 1/1] mm/vmalloc.c: correct logic errors when insert vmap_area

2016-10-20 Thread zijun_hu
On 10/13/2016 02:39 PM, zijun_hu wrote: Hi Nicholas, could you give some comments for this patch? thanks a lot > Hi Nicholas, > > i find __insert_vmap_area() is introduced by you > could you offer comments for this patch related to that funciton > > thanks > > On 10/12/2016 10:46 PM, Michal Ho

Re: [RFC PATCH 1/1] mm/vmalloc.c: correct logic errors when insert vmap_area

2016-10-12 Thread zijun_hu
Hi Nicholas, i find __insert_vmap_area() is introduced by you could you offer comments for this patch related to that funciton thanks On 10/12/2016 10:46 PM, Michal Hocko wrote: > [Let's CC Nick who has written this code] > > On Wed 12-10-16 22:30:13, zijun_hu wrote: >> From: zijun_hu >> >> th

Re: [RFC PATCH 1/1] mm/vmalloc.c: correct logic errors when insert vmap_area

2016-10-12 Thread zijun_hu
On 2016/10/12 22:46, Michal Hocko wrote: > [Let's CC Nick who has written this code] > > On Wed 12-10-16 22:30:13, zijun_hu wrote: >> From: zijun_hu >> >> the KVA allocator organizes vmap_areas allocated by rbtree. in order to >> insert a new vmap_area @i_va into the rbtree, walk around the rbtre

Re: [RFC PATCH 1/1] mm/vmalloc.c: correct logic errors when insert vmap_area

2016-10-12 Thread Michal Hocko
[Let's CC Nick who has written this code] On Wed 12-10-16 22:30:13, zijun_hu wrote: > From: zijun_hu > > the KVA allocator organizes vmap_areas allocated by rbtree. in order to > insert a new vmap_area @i_va into the rbtree, walk around the rbtree from > root and compare the vmap_area @t_va met

[RFC PATCH 1/1] mm/vmalloc.c: correct logic errors when insert vmap_area

2016-10-12 Thread zijun_hu
From: zijun_hu the KVA allocator organizes vmap_areas allocated by rbtree. in order to insert a new vmap_area @i_va into the rbtree, walk around the rbtree from root and compare the vmap_area @t_va met on the rbtree against @i_va; walk toward the left branch of @t_va if @i_va is lower than @t_va,