Re: [RFC PATCH 02/11] x86,fpu: replace fpu_switch_t with a thread flag

2015-01-13 Thread Oleg Nesterov
On 01/13, Rik van Riel wrote: > > On 01/13/2015 10:24 AM, Oleg Nesterov wrote: > > Rik, > > > > I can't review this series, I forgot almost everything I learned > > about this code. The only thing I can recall is that it needs > > cleanups and fixes ;) Just a couple of random questions. > > > > On

Re: [RFC PATCH 02/11] x86,fpu: replace fpu_switch_t with a thread flag

2015-01-13 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2015 10:24 AM, Oleg Nesterov wrote: > Rik, > > I can't review this series, I forgot almost everything I learned > about this code. The only thing I can recall is that it needs > cleanups and fixes ;) Just a couple of random questions. > > On

Re: [RFC PATCH 02/11] x86,fpu: replace fpu_switch_t with a thread flag

2015-01-13 Thread Oleg Nesterov
Rik, I can't review this series, I forgot almost everything I learned about this code. The only thing I can recall is that it needs cleanups and fixes ;) Just a couple of random questions. On 01/11, r...@redhat.com wrote: > > +static inline void switch_fpu_prepare(struct task_struct *old, struct

[RFC PATCH 02/11] x86,fpu: replace fpu_switch_t with a thread flag

2015-01-11 Thread riel
From: Rik van Riel Replace fpu_switch_t with a thread flag, in preparation for only restoring the FPU state on return to user space. I have left the code around fpu_lazy_restore intact, even though there appears to be no protection against races with eg. ptrace, and the optimization appears equa