Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-07 Thread Yang Shi
On Wed, Apr 7, 2021 at 1:32 AM Mel Gorman wrote: > > On Tue, Apr 06, 2021 at 09:42:07AM -0700, Yang Shi wrote: > > On Tue, Apr 6, 2021 at 5:03 AM Gerald Schaefer > > wrote: > > > > > > On Thu, 1 Apr 2021 13:10:49 -0700 > > > Yang Shi wrote: > > > > > > [...] > > > > > > > > > > > > Yes, it could

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-07 Thread Mel Gorman
On Tue, Apr 06, 2021 at 09:42:07AM -0700, Yang Shi wrote: > On Tue, Apr 6, 2021 at 5:03 AM Gerald Schaefer > wrote: > > > > On Thu, 1 Apr 2021 13:10:49 -0700 > > Yang Shi wrote: > > > > [...] > > > > > > > > > > Yes, it could be. The old behavior of migration was to return -ENOMEM > > > > > if TH

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-06 Thread Yang Shi
On Tue, Apr 6, 2021 at 5:03 AM Gerald Schaefer wrote: > > On Thu, 1 Apr 2021 13:10:49 -0700 > Yang Shi wrote: > > [...] > > > > > > > > Yes, it could be. The old behavior of migration was to return -ENOMEM > > > > if THP migration is not supported then split THP. That behavior was > > > > not ver

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-06 Thread Gerald Schaefer
On Thu, 1 Apr 2021 13:10:49 -0700 Yang Shi wrote: [...] > > > > > > Yes, it could be. The old behavior of migration was to return -ENOMEM > > > if THP migration is not supported then split THP. That behavior was > > > not very friendly to some usecases, for example, memory policy and > > > migrat

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-01 Thread Yang Shi
On Wed, Mar 31, 2021 at 6:20 AM Mel Gorman wrote: > > On Tue, Mar 30, 2021 at 04:42:00PM +0200, Gerald Schaefer wrote: > > Could there be a work-around by splitting THP pages instead of marking them > > as migrate pmds (via pte swap entries), at least when THP migration is not > > supported? I gue

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-01 Thread Yang Shi
On Wed, Mar 31, 2021 at 4:47 AM Gerald Schaefer wrote: > > On Tue, 30 Mar 2021 09:51:46 -0700 > Yang Shi wrote: > > > On Tue, Mar 30, 2021 at 7:42 AM Gerald Schaefer > > wrote: > > > > > > On Mon, 29 Mar 2021 11:33:06 -0700 > > > Yang Shi wrote: > > > > > > > > > > > When the THP NUMA fault sup

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-03-31 Thread Mel Gorman
On Tue, Mar 30, 2021 at 04:42:00PM +0200, Gerald Schaefer wrote: > Could there be a work-around by splitting THP pages instead of marking them > as migrate pmds (via pte swap entries), at least when THP migration is not > supported? I guess it could also be acceptable if THP pages were simply not >

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-03-31 Thread Gerald Schaefer
On Tue, 30 Mar 2021 09:51:46 -0700 Yang Shi wrote: > On Tue, Mar 30, 2021 at 7:42 AM Gerald Schaefer > wrote: > > > > On Mon, 29 Mar 2021 11:33:06 -0700 > > Yang Shi wrote: > > > > > > > > When the THP NUMA fault support was added THP migration was not supported > > > yet. > > > So the ad ho

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-03-30 Thread Yang Shi
On Tue, Mar 30, 2021 at 7:42 AM Gerald Schaefer wrote: > > On Mon, 29 Mar 2021 11:33:06 -0700 > Yang Shi wrote: > > > > > When the THP NUMA fault support was added THP migration was not supported > > yet. > > So the ad hoc THP migration was implemented in NUMA fault handling. Since > > v4.14 >

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-03-30 Thread Gerald Schaefer
On Mon, 29 Mar 2021 11:33:06 -0700 Yang Shi wrote: > > When the THP NUMA fault support was added THP migration was not supported yet. > So the ad hoc THP migration was implemented in NUMA fault handling. Since > v4.14 > THP migration has been supported so it doesn't make too much sense to stil

[RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-03-29 Thread Yang Shi
When the THP NUMA fault support was added THP migration was not supported yet. So the ad hoc THP migration was implemented in NUMA fault handling. Since v4.14 THP migration has been supported so it doesn't make too much sense to still keep another THP migration implementation rather than using t