On 7/2/15 2:24 AM, Wangnan (F) wrote:
Yes, by using perf_trace_buf_prepare() + perf_trace_buf_submit() in
helper function and let bpf program always returns 0 we can make data
collected by BPF programs output into samples, if following problems
are solved:
1. In bpf program there's no way to g
On Wed, Jul 01, 2015 at 07:48:25PM -0700, Alexei Starovoitov wrote:
> On 7/1/15 4:58 AM, Peter Zijlstra wrote:
> >
> >But why create a separate trace buffer, it should go into the regular
> >perf buffer.
>
> +1
>
> I think
> +static char __percpu *perf_extra_trace_buf[PERF_NR_CONTEXTS];
> is redu
On 2015/7/2 11:52, Alexei Starovoitov wrote:
On 7/1/15 8:38 PM, He Kuang wrote:
On 2015/7/2 10:48, Alexei Starovoitov wrote:
On 7/1/15 4:58 AM, Peter Zijlstra wrote:
But why create a separate trace buffer, it should go into the regular
perf buffer.
+1
I think
+static char __percpu *per
On 7/1/15 8:38 PM, He Kuang wrote:
On 2015/7/2 10:48, Alexei Starovoitov wrote:
On 7/1/15 4:58 AM, Peter Zijlstra wrote:
But why create a separate trace buffer, it should go into the regular
perf buffer.
+1
I think
+static char __percpu *perf_extra_trace_buf[PERF_NR_CONTEXTS];
is redundan
On 2015/7/2 10:48, Alexei Starovoitov wrote:
On 7/1/15 4:58 AM, Peter Zijlstra wrote:
But why create a separate trace buffer, it should go into the regular
perf buffer.
+1
I think
+static char __percpu *perf_extra_trace_buf[PERF_NR_CONTEXTS];
is redundant.
It adds quite a bit of unnecessar
On 7/1/15 4:58 AM, Peter Zijlstra wrote:
But why create a separate trace buffer, it should go into the regular
perf buffer.
+1
I think
+static char __percpu *perf_extra_trace_buf[PERF_NR_CONTEXTS];
is redundant.
It adds quite a bit of unnecessary complexity to the whole patch set.
Also the c
On Wed, Jul 01, 2015 at 02:21:11PM +0800, Wangnan (F) wrote:
>
>
> On 2015/7/1 13:44, Peter Zijlstra wrote:
> >On Wed, Jul 01, 2015 at 02:57:30AM +, He Kuang wrote:
> >>This patch adds an extra perf trace buffer for other utilities like
> >>bpf to fill extra data to perf events.
> >What!, why
On 2015/7/1 13:44, Peter Zijlstra wrote:
On Wed, Jul 01, 2015 at 02:57:30AM +, He Kuang wrote:
This patch adds an extra perf trace buffer for other utilities like
bpf to fill extra data to perf events.
What!, why?
The goal of this patchset is to give BPF program a mean to output
someth
On Wed, Jul 01, 2015 at 02:57:30AM +, He Kuang wrote:
> This patch adds an extra perf trace buffer for other utilities like
> bpf to fill extra data to perf events.
What!, why?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
The idea to let eBPF output data to perf sample event was first
metioned in "[RFC PATCH v4 10/29] bpf tools: Collect map definitions
from 'maps' section", and the output data is not limited to PMU
counters but data like time latencies, cache misses or other things
users want to record.
This patch
10 matches
Mail list logo