Re: [RFC PATCH] uprobes: simplify rip-relative handling

2014-04-27 Thread Oleg Nesterov
On 04/27, Oleg Nesterov wrote: > > On 04/26, Denys Vlasenko wrote: > > > > @@ -46,7 +46,7 @@ struct arch_uprobe { > > > > union { > > #ifdef CONFIG_X86_64 > > - unsigned long rip_rela_target_address; > > + int insn_length; > >

Re: [RFC PATCH] uprobes: simplify rip-relative handling

2014-04-27 Thread Oleg Nesterov
On 04/26, Denys Vlasenko wrote: > > @@ -46,7 +46,7 @@ struct arch_uprobe { > > union { > #ifdef CONFIG_X86_64 > - unsigned long rip_rela_target_address; > + int insn_length; > #endif in particular, we already have aupr

[RFC PATCH] uprobes: simplify rip-relative handling

2014-04-26 Thread Denys Vlasenko
It is possible to replace rip-relative addressing mode with addressing mode of the same length: [reg+disp32]. This eliminates the need to fix up immediate. Only Signed-off-by: Denys Vlasenko CC: Jim Keniston CC: Masami Hiramatsu CC: Oleg Nesterov --- arch/x86/include/asm/uprobes.h | 2 +- a