Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-08 Thread Lennart Sorensen
On Tue, Jul 08, 2014 at 06:46:58PM +0200, Sebastian Andrzej Siewior wrote: > I just managed to boot my dra7-evm on mainline. It crashed in > serial_omap_runtime_resume(). Now that is fixed. The next post should > have this fixed and work (at least on v3.16-rc). Sounds good. I am still stuck on 3.

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-08 Thread Sebastian Andrzej Siewior
On 07/04/2014 08:13 PM, Lennart Sorensen wrote: > I get a segfault at this line: > > mvr = uart_read(up, UART_OMAP_MVER); > > I added it to ti's 3.12.y kernel and ran it on uart7 and uart8 on > a dra7xx-evm as a module (built in the kernel never booted due to > the crash). I just managed to boot

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-07 Thread One Thousand Gnomes
On Fri, 4 Jul 2014 11:57:40 -0500 Robert Nelson wrote: > On Fri, Jul 4, 2014 at 11:51 AM, Sebastian Andrzej Siewior > wrote: > > On 07/03/2014 09:34 AM, Tony Lindgren wrote: > >> Heh. Just to summarize the reason ttyO needs to be a separate name > >> and device entry from ttyS is because we also

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-07 Thread Tony Lindgren
* Robert Nelson [140704 09:59]: > On Fri, Jul 4, 2014 at 11:51 AM, Sebastian Andrzej Siewior > wrote: > > On 07/03/2014 09:34 AM, Tony Lindgren wrote: > >> Heh. Just to summarize the reason ttyO needs to be a separate name > >> and device entry from ttyS is because we also have external 8250 > >>

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-04 Thread Lennart Sorensen
On Thu, Jul 03, 2014 at 02:48:08PM -0400, Lennart Sorensen wrote: > On Wed, Jul 02, 2014 at 06:00:09PM +0200, Sebastian Andrzej Siewior wrote: > > This patch provides a 8250-core based UART driver for the internal OMAP > > UART. The longterm goal is to provide the same functionality as the > > curr

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-04 Thread Peter Maydell
On 2 July 2014 20:09, Aaro Koskinen wrote: > When ttyS -> ttyO change was done on OMAP, compatibility was not an issue. > Why should we care about it now? You should have cared about it back then as well -- it was really annoying and required everybody running an OMAP based board to suddenly fix

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-04 Thread Robert Nelson
On Fri, Jul 4, 2014 at 11:51 AM, Sebastian Andrzej Siewior wrote: > On 07/03/2014 09:34 AM, Tony Lindgren wrote: >> Heh. Just to summarize the reason ttyO needs to be a separate name >> and device entry from ttyS is because we also have external 8250 >> devices on GPMC and hotplug busses. > > So t

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-04 Thread Sebastian Andrzej Siewior
On 07/03/2014 09:34 AM, Tony Lindgren wrote: > Heh. Just to summarize the reason ttyO needs to be a separate name > and device entry from ttyS is because we also have external 8250 > devices on GPMC and hotplug busses. So the GPMC devices will first get a higher minor/device number. The internal s

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Tony Lindgren
* Felipe Balbi [140703 10:10]: > On Thu, Jul 03, 2014 at 06:19:47PM +0200, Javier Martinez Canillas wrote: > > On Thu, Jul 3, 2014 at 6:06 PM, Sebastian Reichel wrote: > > > Hi, > > > > > > On Thu, Jul 03, 2014 at 10:52:40AM -0500, Felipe Balbi wrote: > > >> > DT is supposed to contain informatio

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Lennart Sorensen
On Wed, Jul 02, 2014 at 06:00:09PM +0200, Sebastian Andrzej Siewior wrote: > This patch provides a 8250-core based UART driver for the internal OMAP > UART. The longterm goal is to provide the same functionality as the > current OMAP uart driver and hopefully DMA support which could borrowed > from

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Felipe Balbi
On Thu, Jul 03, 2014 at 06:19:47PM +0200, Javier Martinez Canillas wrote: > On Thu, Jul 3, 2014 at 6:06 PM, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Jul 03, 2014 at 10:52:40AM -0500, Felipe Balbi wrote: > >> > DT is supposed to contain information about the hardware, so it > >> > should st

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Javier Martinez Canillas
On Thu, Jul 3, 2014 at 6:06 PM, Sebastian Reichel wrote: > Hi, > > On Thu, Jul 03, 2014 at 10:52:40AM -0500, Felipe Balbi wrote: >> > DT is supposed to contain information about the hardware, so it >> > should stay the same? I think there is no non-hackish way to decide >> >> compatible would chan

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Sebastian Reichel
Hi, On Thu, Jul 03, 2014 at 10:52:40AM -0500, Felipe Balbi wrote: > > DT is supposed to contain information about the hardware, so it > > should stay the same? I think there is no non-hackish way to decide > > compatible would change, at a minimum. why? I would expect it to stay the same (and th

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Felipe Balbi
On Thu, Jul 03, 2014 at 05:44:26PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Jul 03, 2014 at 09:07:36AM -0500, Felipe Balbi wrote: > > On Thu, Jul 03, 2014 at 08:34:44AM -0500, Robert Nelson wrote: > > > On Thu, Jul 3, 2014 at 8:25 AM, Felipe Balbi wrote: > > > > On Thu, Jul 03, 2014 at 1

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Sebastian Reichel
Hi, On Thu, Jul 03, 2014 at 09:07:36AM -0500, Felipe Balbi wrote: > On Thu, Jul 03, 2014 at 08:34:44AM -0500, Robert Nelson wrote: > > On Thu, Jul 3, 2014 at 8:25 AM, Felipe Balbi wrote: > > > On Thu, Jul 03, 2014 at 12:34:11AM -0700, Tony Lindgren wrote: > > >> * Robert Nelson [140702 12:27]: >

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Felipe Balbi
On Thu, Jul 03, 2014 at 08:34:44AM -0500, Robert Nelson wrote: > On Thu, Jul 3, 2014 at 8:25 AM, Felipe Balbi wrote: > > On Thu, Jul 03, 2014 at 12:34:11AM -0700, Tony Lindgren wrote: > >> * Robert Nelson [140702 12:27]: > >> > On Wed, Jul 2, 2014 at 2:09 PM, Aaro Koskinen > >> > wrote: > >> >

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Robert Nelson
On Thu, Jul 3, 2014 at 8:25 AM, Felipe Balbi wrote: > On Thu, Jul 03, 2014 at 12:34:11AM -0700, Tony Lindgren wrote: >> * Robert Nelson [140702 12:27]: >> > On Wed, Jul 2, 2014 at 2:09 PM, Aaro Koskinen wrote: >> > > Hi, >> > > >> > > On Wed, Jul 02, 2014 at 11:09:32AM -0500, Felipe Balbi wrote:

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Felipe Balbi
On Thu, Jul 03, 2014 at 12:34:11AM -0700, Tony Lindgren wrote: > * Robert Nelson [140702 12:27]: > > On Wed, Jul 2, 2014 at 2:09 PM, Aaro Koskinen wrote: > > > Hi, > > > > > > On Wed, Jul 02, 2014 at 11:09:32AM -0500, Felipe Balbi wrote: > > >> > It has been only tested as console UART. > > >> >

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-03 Thread Tony Lindgren
* Robert Nelson [140702 12:27]: > On Wed, Jul 2, 2014 at 2:09 PM, Aaro Koskinen wrote: > > Hi, > > > > On Wed, Jul 02, 2014 at 11:09:32AM -0500, Felipe Balbi wrote: > >> > It has been only tested as console UART. > >> > The tty name is ttyS based instead of ttyO. How big is the pain here, > >> >

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-02 Thread Robert Nelson
On Wed, Jul 2, 2014 at 2:09 PM, Aaro Koskinen wrote: > Hi, > > On Wed, Jul 02, 2014 at 11:09:32AM -0500, Felipe Balbi wrote: >> > It has been only tested as console UART. >> > The tty name is ttyS based instead of ttyO. How big is the pain here, >> > what could be the easiest way to provide compat

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-02 Thread Aaro Koskinen
Hi, On Wed, Jul 02, 2014 at 11:09:32AM -0500, Felipe Balbi wrote: > > It has been only tested as console UART. > > The tty name is ttyS based instead of ttyO. How big is the pain here, > > what could be the easiest way to provide compatibility? > > have been considering that myself for months. Yo

Re: [RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-02 Thread Felipe Balbi
Hi, +linux-omap, lakml On Wed, Jul 02, 2014 at 06:00:09PM +0200, Sebastian Andrzej Siewior wrote: > This patch provides a 8250-core based UART driver for the internal OMAP > UART. The longterm goal is to provide the same functionality as the > current OMAP uart driver and hopefully DMA support wh

[RFC PATCH] tty: serial: Add 8250-core based omap driver

2014-07-02 Thread Sebastian Andrzej Siewior
This patch provides a 8250-core based UART driver for the internal OMAP UART. The longterm goal is to provide the same functionality as the current OMAP uart driver and hopefully DMA support which could borrowed from the 8250-core. The whole PM-Runtime part is currently missing. It has been only t