Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-31 Thread Mel Gorman
On Thu, Aug 31, 2017 at 11:07:22AM +0200, Pavel Machek wrote: > > > > "This allocation is temporary. It lasts milliseconds, not hours." > > > > > > It isn't sufficient to give a rule for when GFP_TEMPORARY will be used, > > > you also need to explain (at least in general terms) how the information

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-31 Thread Pavel Machek
Hi! > > > > You can define more exact meaning, and then adjust the usage. But > > > > there's no need to do treewide replacement... > > > > > > I have checked most of them and except for the initially added onces the > > > large portion where added without a good reasons or even break an > > > in

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-31 Thread Pavel Machek
Hi! > > > "This allocation is temporary. It lasts milliseconds, not hours." > > > > It isn't sufficient to give a rule for when GFP_TEMPORARY will be used, > > you also need to explain (at least in general terms) how the information > > will be used. Also you need to give guidelines on whether t

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-28 Thread Michal Hocko
On Sat 26-08-17 14:11:33, NeilBrown wrote: > On Fri, Aug 25 2017, Pavel Machek wrote: > > > On Fri 2017-08-25 10:04:42, Michal Hocko wrote: > >> On Fri 25-08-17 09:28:19, Pavel Machek wrote: > >> > On Fri 2017-08-25 08:35:46, Michal Hocko wrote: > >> > > On Wed 23-08-17 19:57:09, Pavel Machek wrot

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-28 Thread Michal Hocko
On Fri 25-08-17 23:39:36, Pavel Machek wrote: > On Fri 2017-08-25 10:04:42, Michal Hocko wrote: > > On Fri 25-08-17 09:28:19, Pavel Machek wrote: > > > On Fri 2017-08-25 08:35:46, Michal Hocko wrote: > > > > On Wed 23-08-17 19:57:09, Pavel Machek wrote: > > [...] > > > > > Dunno. < 1msec probably i

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-25 Thread NeilBrown
On Fri, Aug 25 2017, Pavel Machek wrote: > On Fri 2017-08-25 10:04:42, Michal Hocko wrote: >> On Fri 25-08-17 09:28:19, Pavel Machek wrote: >> > On Fri 2017-08-25 08:35:46, Michal Hocko wrote: >> > > On Wed 23-08-17 19:57:09, Pavel Machek wrote: >> [...] >> > > > Dunno. < 1msec probably is tempora

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-25 Thread Pavel Machek
On Fri 2017-08-25 10:04:42, Michal Hocko wrote: > On Fri 25-08-17 09:28:19, Pavel Machek wrote: > > On Fri 2017-08-25 08:35:46, Michal Hocko wrote: > > > On Wed 23-08-17 19:57:09, Pavel Machek wrote: > [...] > > > > Dunno. < 1msec probably is temporary, 1 hour probably is not. If it > > > > causes

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-25 Thread Michal Hocko
On Fri 25-08-17 09:28:19, Pavel Machek wrote: > On Fri 2017-08-25 08:35:46, Michal Hocko wrote: > > On Wed 23-08-17 19:57:09, Pavel Machek wrote: [...] > > > Dunno. < 1msec probably is temporary, 1 hour probably is not. If it causes > > > problems, can you just #define GFP_TEMPORARY GFP_KERNEL ? Tr

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-25 Thread Pavel Machek
On Fri 2017-08-25 08:35:46, Michal Hocko wrote: > On Wed 23-08-17 19:57:09, Pavel Machek wrote: > > Hi! > > > > > From: Michal Hocko > > > > > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > > > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > >

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-24 Thread Michal Hocko
On Wed 23-08-17 19:57:09, Pavel Machek wrote: > Hi! > > > From: Michal Hocko > > > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > > primary motivation was to allow users to tell that an allocat

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-08-24 Thread Pavel Machek
Hi! > From: Michal Hocko > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > primary motivation was to allow users to tell that an allocation is > short lived and so the allocator can try to place s

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-07-28 Thread Vlastimil Babka
On 07/28/2017 11:19 AM, Michal Hocko wrote: > From: Michal Hocko > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > primary motivation was to allow users to tell that an allocation is > short lived

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-07-28 Thread Mel Gorman
On Fri, Jul 28, 2017 at 12:27:43PM +0200, Michal Hocko wrote: > On Fri 28-07-17 10:52:49, Mel Gorman wrote: > > On Fri, Jul 28, 2017 at 11:19:04AM +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > > > and reclai

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-07-28 Thread Michal Hocko
On Fri 28-07-17 10:52:49, Mel Gorman wrote: > On Fri, Jul 28, 2017 at 11:19:04AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > > primary

Re: [RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-07-28 Thread Mel Gorman
On Fri, Jul 28, 2017 at 11:19:04AM +0200, Michal Hocko wrote: > From: Michal Hocko > > GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived > and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's > primary motivation was to allow users to tell that an allocation

[RFC PATCH] treewide: remove GFP_TEMPORARY allocation flag

2017-07-28 Thread Michal Hocko
From: Michal Hocko GFP_TEMPORARY has been introduced by e12ba74d8ff3 ("Group short-lived and reclaimable kernel allocations") along with __GFP_RECLAIMABLE. It's primary motivation was to allow users to tell that an allocation is short lived and so the allocator can try to place such allocations c