Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-26 Thread Eiichi Tsukata
(2013/08/23 21:26), Ric Wheeler wrote: On 08/23/2013 05:10 AM, Eiichi Tsukata wrote: (2013/08/21 3:09), Ewan Milne wrote: On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: (2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-26 Thread Eiichi Tsukata
(2013/08/24 4:36), Ewan Milne wrote: On Fri, 2013-08-23 at 06:19 -0700, James Bottomley wrote: On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: Yes, basically the device should be offlined on error detection. Just offlining the disk is enough when an error occurs on "not" os-installed s

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-26 Thread Eiichi Tsukata
(2013/08/23 22:19), James Bottomley wrote: On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: (2013/08/21 3:09), Ewan Milne wrote: On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: (2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote:

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread Ewan Milne
On Fri, 2013-08-23 at 06:19 -0700, James Bottomley wrote: > On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: > > Yes, basically the device should be offlined on error detection. > > Just offlining the disk is enough when an error occurs on "not" os-installed > > system disk. Panic is going

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread James Bottomley
On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: > (2013/08/21 3:09), Ewan Milne wrote: > > On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: > >> (2013/08/19 23:30), James Bottomley wrote: > >>> On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: > Hello, > > Thi

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread Ric Wheeler
On 08/23/2013 05:10 AM, Eiichi Tsukata wrote: (2013/08/21 3:09), Ewan Milne wrote: On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: (2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This patch adds scsi device failfast mode to

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread Eiichi Tsukata
(2013/08/21 3:09), Ewan Milne wrote: On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: (2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This patch adds scsi device failfast mode to avoid infinite retry loop. Currently, scsi err

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-20 Thread Ewan Milne
On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: > (2013/08/19 23:30), James Bottomley wrote: > > On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: > >> Hello, > >> > >> This patch adds scsi device failfast mode to avoid infinite retry loop. > >> > >> Currently, scsi error handling i

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-20 Thread Eiichi Tsukata
(2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This patch adds scsi device failfast mode to avoid infinite retry loop. Currently, scsi error handling in scsi_decide_disposition() and scsi_io_completion() unconditionally retries on som

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-19 Thread James Bottomley
On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: > Hello, > > This patch adds scsi device failfast mode to avoid infinite retry loop. > > Currently, scsi error handling in scsi_decide_disposition() and > scsi_io_completion() unconditionally retries on some errors. This is because > retrya

[RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-19 Thread Eiichi Tsukata
Hello, This patch adds scsi device failfast mode to avoid infinite retry loop. Currently, scsi error handling in scsi_decide_disposition() and scsi_io_completion() unconditionally retries on some errors. This is because retryable errors are thought to be temporary and the scsi device will soon re