Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Alex Shi
On 01/17/2014 11:36 AM, Mike Galbraith wrote: > + > > >>> + /* skip single group domain */ > > >>> + if (sg == sg->next) > > >>> + continue; >>> > > >>> > > When is that gonna happen? >> > >> > I had seen this in a Intel platform, you may have

Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Mike Galbraith
On Fri, 2014-01-17 at 10:14 +0800, Alex Shi wrote: > On 01/16/2014 09:52 PM, Mike Galbraith wrote: > > On Thu, 2014-01-16 at 21:13 +0800, Alex Shi wrote: > >> Add Mike Galbraith. > >> > >> Any one like to give some comments? > >> > >> On 01/15/2014 10:23 PM, Alex Shi wrote: > >>> If the sd domain

Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Michael wang
On 01/17/2014 10:14 AM, Alex Shi wrote: [snip] >> >> When is that gonna happen? > > I had seen this in a Intel platform, you may have both CPU domain and MC > domain layer, because the domain flag is different, then they can not be > merged. and then the CPU domain just has one group. CPU and MC

Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Alex Shi
On 01/16/2014 09:52 PM, Mike Galbraith wrote: > On Thu, 2014-01-16 at 21:13 +0800, Alex Shi wrote: >> Add Mike Galbraith. >> >> Any one like to give some comments? >> >> On 01/15/2014 10:23 PM, Alex Shi wrote: >>> If the sd domain just has one group, then we must be caught the >>> i == target

Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Mike Galbraith
On Thu, 2014-01-16 at 21:13 +0800, Alex Shi wrote: > Add Mike Galbraith. > > Any one like to give some comments? > > On 01/15/2014 10:23 PM, Alex Shi wrote: > > If the sd domain just has one group, then we must be caught the > > i == target later, and then goes to deeper level domain. > > So

Re: [RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-16 Thread Alex Shi
Add Mike Galbraith. Any one like to give some comments? On 01/15/2014 10:23 PM, Alex Shi wrote: > If the sd domain just has one group, then we must be caught the > i == target later, and then goes to deeper level domain. > So just skip this domain checking to save some instructions. > > Si

[RFC PATCH] sched: select_idle_sibling macro optimize

2014-01-15 Thread Alex Shi
If the sd domain just has one group, then we must be caught the i == target later, and then goes to deeper level domain. So just skip this domain checking to save some instructions. Signed-off-by: Alex Shi --- kernel/sched/fair.c | 5 + 1 file changed, 5 insertions(+) diff --git a/k