Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-04-01 Thread Peter Zijlstra
On Fri, Apr 01, 2016 at 02:40:32PM -0700, Steve Muckle wrote: > On 03/31/2016 02:14 AM, Peter Zijlstra wrote: > > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: > >>> > > - passing an argument into attach_entity_load_avg() to indicate > >>> > >

Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-04-01 Thread Steve Muckle
On 03/31/2016 02:14 AM, Peter Zijlstra wrote: > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: >>> > > - passing an argument into attach_entity_load_avg() to indicate >>> > > >>> > >whether calling the cpufreq hook is necessary

Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-03-31 Thread Rafael J. Wysocki
On Thu, Mar 31, 2016 at 11:14 AM, Peter Zijlstra wrote: > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: >> > - passing an argument into attach_entity_load_avg() to indicate >> >whether calling the cpufreq hook is necessary >> > >> > Both of these are ugly in their own way bu

Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-03-31 Thread Peter Zijlstra
On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: > > - passing an argument into attach_entity_load_avg() to indicate > > > >whether calling the cpufreq hook is necessary > > > > Both of these are ugly in their own way but would

Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-03-31 Thread Peter Zijlstra
On Thu, Mar 24, 2016 at 03:26:07PM -0700, Steve Muckle wrote: > Note that this patch depends on the 2 patches I sent several days ago: > http://thread.gmane.org/gmane.linux.kernel/2181498 Right; I had something similar for a little while.. > Unfortunately this means that in the migration case, >

[RFC PATCH] sched/fair: call cpufreq hook in additional paths

2016-03-24 Thread Steve Muckle
The cpufreq hook should be called any time the root CFS rq utilization changes. This can occur when a task is switched to or from the fair class, or a task moves between groups or CPUs, but these paths currently do not call the cpufreq hook. Fix this by adding the hook to attach_entity_load_avg()