Re: [RFC PATCH] lpfc: Add lockdep assertions

2015-12-17 Thread Bart Van Assche
On 12/17/2015 09:49 AM, Johannes Thumshirn wrote: On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote: Johannes, Thank you for the time and effort on the patch. At this time, as it doesn't functionally change anything, I did not include the patch. I will consider it if we see additional

Re: [RFC PATCH] lpfc: Add lockdep assertions

2015-12-17 Thread Johannes Thumshirn
On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote: > Johannes, > > Thank you for the time and effort on the patch. At this time, as it doesn't > functionally change anything, I did not include the patch. I will consider > it if we see additional issues it can help resolve. As I already

Re: [RFC PATCH] lpfc: Add lockdep assertions

2015-12-16 Thread Bart Van Assche
On 11/20/2015 01:37 PM, Johannes Thumshirn wrote: Several functions in lpfc have comments stating that the function must be called with the hbalock (or hostlock, or ringlock) held. Add lockdep_assert_held() annotations to these functions, so one can actually verify the locks are held. [ ... ] @

Re: [RFC PATCH] lpfc: Add lockdep assertions

2015-12-16 Thread James Smart
Johannes, Thank you for the time and effort on the patch. At this time, as it doesn't functionally change anything, I did not include the patch. I will consider it if we see additional issues it can help resolve. -- james s On 11/20/2015 4:37 AM, Johannes Thumshirn wrote: Several functions

[RFC PATCH] lpfc: Add lockdep assertions

2015-11-20 Thread Johannes Thumshirn
Several functions in lpfc have comments stating that the function must be called with the hbalock (or hostlock, or ringlock) held. Add lockdep_assert_held() annotations to these functions, so one can actually verify the locks are held. Signed-off-by: Johannes Thumshirn --- I'm not sure if this i