Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

2013-06-28 Thread Denys Vlasenko
On Wednesday 29 May 2013 23:56, James Hogan wrote: > On 29 May 2013 18:36, Oleg Nesterov wrote: > > On 05/29, David Daney wrote: > >> > >> On 05/29/2013 10:01 AM, James Hogan wrote: > >>> MIPS has 128 signals, the highest of which has the number 128. The > >> > >> I wonder if we should change the

Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

2013-05-29 Thread James Hogan
On 29 May 2013 18:36, Oleg Nesterov wrote: > On 05/29, David Daney wrote: >> >> On 05/29/2013 10:01 AM, James Hogan wrote: >>> MIPS has 128 signals, the highest of which has the number 128. The >> >> I wonder if we should change the ABI and reduce the number of signals to >> 127 instead of this pa

Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

2013-05-29 Thread Oleg Nesterov
On 05/29, David Daney wrote: > > On 05/29/2013 10:01 AM, James Hogan wrote: >> MIPS has 128 signals, the highest of which has the number 128. The > > I wonder if we should change the ABI and reduce the number of signals to > 127 instead of this patch. Same thoughts... >> @@ -2366,8 +2366,12 @@ re

Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

2013-05-29 Thread David Daney
On 05/29/2013 10:01 AM, James Hogan wrote: MIPS has 128 signals, the highest of which has the number 128. The I wonder if we should change the ABI and reduce the number of signals to 127 instead of this patch. David Daney following command causes get_signal_to_deliver() to pass this sign

[RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

2013-05-29 Thread James Hogan
MIPS has 128 signals, the highest of which has the number 128. The following command causes get_signal_to_deliver() to pass this signal number straight through to do_group_exit() as the exit code: strace sleep 10 & sleep 1 && kill -128 `pidof sleep` However do_group_exit() checks for the core d