Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all panic() > invocations - and the

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 22:50:19 +0200 Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Kees Cook
On Tue, Oct 9, 2018 at 1:50 PM, Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all panic(

[RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Borislav Petkov
From: Borislav Petkov If a call to panic() terminates the string with a \n, the result puts the closing brace ']---' on a newline because panic() itself adds \n too. Now, if one goes and removes the newline chars from all panic() invocations - and the stats right now look like this: ~300 calls