Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-23 Thread Michal Hocko
On Tue 23-08-16 17:27:11, Oleg Nesterov wrote: > On 08/19, Michal Hocko wrote: [...] > > or we do not care about this > > "regression" > > Honestly, I do not know ;) Personally, I am always scared when it comes > to the subtle changes like this, you can never know what can be broken. If _you_ are

Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-23 Thread Oleg Nesterov
On 08/19, Michal Hocko wrote: > > On Fri 12-08-16 11:41:13, Michal Hocko wrote: > > On Wed 03-08-16 23:08:04, Oleg Nesterov wrote: > > > > > > So if we want this change, why we can't simply do > > > > > > - if (!(tsk->flags & PF_SIGNALED) && > > > + if (!(tsk->signal->flags & SIGNAL

Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-19 Thread Michal Hocko
On Fri 12-08-16 11:41:13, Michal Hocko wrote: > On Wed 03-08-16 23:08:04, Oleg Nesterov wrote: > > sorry for delay, I am travelling till the end of the week. > > Same here... > > > On 08/01, Michal Hocko wrote: [...] > > > We should also check for vfork because > > > this is killable since d68b46

Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-12 Thread Michal Hocko
On Wed 03-08-16 23:08:04, Oleg Nesterov wrote: > sorry for delay, I am travelling till the end of the week. Same here... > On 08/01, Michal Hocko wrote: > > > > fec1d0115240 ("[PATCH] Disable CLONE_CHILD_CLEARTID for abnormal exit") > > almost 10 years ago ;) Yes, it's been a while... I guess n

Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-03 Thread Oleg Nesterov
sorry for delay, I am travelling till the end of the week. On 08/01, Michal Hocko wrote: > > fec1d0115240 ("[PATCH] Disable CLONE_CHILD_CLEARTID for abnormal exit") almost 10 years ago ;) > has caused a subtle regression in nscd which uses CLONE_CHILD_CLEARTID > to clear the nscd_certainly_runni

[RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

2016-08-01 Thread Michal Hocko
From: Michal Hocko fec1d0115240 ("[PATCH] Disable CLONE_CHILD_CLEARTID for abnormal exit") has caused a subtle regression in nscd which uses CLONE_CHILD_CLEARTID to clear the nscd_certainly_running flag in the shared databases, so that the clients are notified when nscd is restarted. Now, when n