Re: [RFC PATCH] checkpatch: check for trivial sizeofs

2020-05-30 Thread Joe Perches
On Sun, 2020-05-31 at 00:21 +0300, Denis Efremov wrote: > sizeof(char) and its variations in most cases doesn't make code more clear. > It only makes code wordy. There are about 1000 of these uses in the kernel. Not sure I like this though as many/most of the uses seem _less_ readable with a 1 in

[RFC PATCH] checkpatch: check for trivial sizeofs

2020-05-30 Thread Denis Efremov
sizeof(char) and its variations in most cases doesn't make code more clear. It only makes code wordy. Signed-off-by: Denis Efremov --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index eac40f0abd56..9dd338b125d2 1