Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 3:02 AM, He Kuang wrote: Here's a hypothetical scenario to illustrate the use of timer map. A video frame is updated between frame_refresh_start() and frame_refresh_end(), in most cases, the interval between these two functions is less than 40ms, but occasionally over 200ms. We can

Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-21 Thread Ingo Molnar
* Wangnan (F) wrote: > > > On 2015/10/21 18:20, Ingo Molnar wrote: > >* He Kuang wrote: > > > >>ping and add a...@plumgrid.com, what's your opinion on this? > >Firstly, two days isn't nearly enough for a 'review timeout', secondly, have > >you > >seen the kbuild test reports? > > > >Thirdly,

Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-21 Thread Wangnan (F)
On 2015/10/21 18:20, Ingo Molnar wrote: * He Kuang wrote: ping and add a...@plumgrid.com, what's your opinion on this? Firstly, two days isn't nearly enough for a 'review timeout', secondly, have you seen the kbuild test reports? Thirdly, I suspect others will do a deeper review, but even

Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-21 Thread Ingo Molnar
* He Kuang wrote: > ping and add a...@plumgrid.com, what's your opinion on this? Firstly, two days isn't nearly enough for a 'review timeout', secondly, have you seen the kbuild test reports? Thirdly, I suspect others will do a deeper review, but even stylistically the patch is a bit weird,

Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-21 Thread He Kuang
ping and add a...@plumgrid.com, what's your opinion on this? On 2015/10/19 13:34, He Kuang wrote: This patch implements a timer map type inherited from array map. eBPF programs can deloy a timer by updating an entry in timer map, and destroy that by deleting the entry. The timer delay time(ns) i

Re: [RFC PATCH] bpf: Add new bpf map type for timer

2015-10-18 Thread kbuild test robot
Hi He, [auto build test WARNING on v4.3-rc6 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/He-Kuang/bpf-Add-new-bpf-map-type-for-timer/20151019-133809 reproduce: # apt-get install sparse

[RFC PATCH] bpf: Add new bpf map type for timer

2015-10-18 Thread He Kuang
This patch implements a timer map type inherited from array map. eBPF programs can deloy a timer by updating an entry in timer map, and destroy that by deleting the entry. The timer delay time(ns) is set by updating the value field of the entries. Currently, an intended empty function is called wh