Re: [RFC PATCH] blk-core: remove blk_put_request()

2021-02-24 Thread Chaitanya Kulkarni
On 2/24/21 10:56, Christoph Hellwig wrote: > On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote: >> Would make sense to rename blk_get_request() to blk_mq_alloc_request() >> and then we have API symmetry. The get/put don't make sense when there >> are no references involved. >> >> But it's

Re: [RFC PATCH] blk-core: remove blk_put_request()

2021-02-24 Thread Christoph Hellwig
On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote: > Would make sense to rename blk_get_request() to blk_mq_alloc_request() > and then we have API symmetry. The get/put don't make sense when there > are no references involved. > > But it's a lot of churn for very little reward, which is a

Re: [RFC PATCH] blk-core: remove blk_put_request()

2021-02-24 Thread Jens Axboe
On 2/24/21 4:53 AM, Stefan Hajnoczi wrote: > On Mon, Feb 22, 2021 at 01:11:15PM -0800, Chaitanya Kulkarni wrote: >> The function blk_put_request() is just a wrapper to >> blk_mq_free_request(), remove the unnecessary wrapper. >> >> Any feedback is welcome on this RFC. >> >> Signed-off-by: Chaitanya

Re: [RFC PATCH] blk-core: remove blk_put_request()

2021-02-24 Thread Stefan Hajnoczi
On Mon, Feb 22, 2021 at 01:11:15PM -0800, Chaitanya Kulkarni wrote: > The function blk_put_request() is just a wrapper to > blk_mq_free_request(), remove the unnecessary wrapper. > > Any feedback is welcome on this RFC. > > Signed-off-by: Chaitanya Kulkarni > --- > block/blk-core.c

[RFC PATCH] blk-core: remove blk_put_request()

2021-02-22 Thread Chaitanya Kulkarni
The function blk_put_request() is just a wrapper to blk_mq_free_request(), remove the unnecessary wrapper. Any feedback is welcome on this RFC. Signed-off-by: Chaitanya Kulkarni --- block/blk-core.c | 6 -- block/blk-merge.c | 2 +- block/bsg-lib.c