Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Dave Hansen
Or, think out of the box... Maybe you can introduce some interfaces that expose information both in sysfs (in normal human-readable formats) and in a way that lets you get the same data out in some binary format. Seems to me you'll have a lot easier time justifying all of these lines of code sp

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Dave Hansen
On Tue, 2007-12-04 at 15:05 -0500, Mathieu Desnoyers wrote: > * Dave Hansen ([EMAIL PROTECTED]) wrote: > > On Tue, 2007-12-04 at 14:25 -0500, Mathieu Desnoyers wrote: > > > > > > - I also dump the equivalent of /proc/swaps (with kernel internal > > > information) at trace start to know what swap

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Mathieu Desnoyers
* Dave Hansen ([EMAIL PROTECTED]) wrote: > On Tue, 2007-12-04 at 14:25 -0500, Mathieu Desnoyers wrote: > > > > - I also dump the equivalent of /proc/swaps (with kernel internal > > information) at trace start to know what swap files are currently > > used. > > What about just enhancing /proc/

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Dave Hansen
On Tue, 2007-12-04 at 14:25 -0500, Mathieu Desnoyers wrote: > > - I also dump the equivalent of /proc/swaps (with kernel internal > information) at trace start to know what swap files are currently > used. What about just enhancing /proc/swaps so that this information can be useful to people

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Mathieu Desnoyers
* Frank Ch. Eigler ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers <[EMAIL PROTECTED]> writes: > > > [...] > >> > We would like to be able to tell which swap file the information has > >> > been written to/read from at any given time during the trace. > >> > >> Oh, tracing is expected to be on at

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-12-04 Thread Frank Ch. Eigler
Mathieu Desnoyers <[EMAIL PROTECTED]> writes: > [...] >> > We would like to be able to tell which swap file the information has >> > been written to/read from at any given time during the trace. >> >> Oh, tracing is expected to be on at all times? I figured someone would >> encounter a problem,

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-11-30 Thread Mathieu Desnoyers
* Dave Hansen ([EMAIL PROTECTED]) wrote: > On Fri, 2007-11-30 at 12:05 -0500, Mathieu Desnoyers wrote: > > > > > > Given a trace including : > > - Swapfiles initially used > > - multiple swapon/swapoff > > - swap in/out events > > > > We would like to be able to tell which swap file the informat

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-11-30 Thread Dave Hansen
On Fri, 2007-11-30 at 12:05 -0500, Mathieu Desnoyers wrote: > > > Given a trace including : > - Swapfiles initially used > - multiple swapon/swapoff > - swap in/out events > > We would like to be able to tell which swap file the information has > been written to/read from at any given time durin

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-11-30 Thread Mathieu Desnoyers
* Dave Hansen ([EMAIL PROTECTED]) wrote: > On Fri, 2007-11-30 at 11:11 -0500, Mathieu Desnoyers wrote: > > +static inline swp_entry_t page_swp_entry(struct page *page) > > +{ > > + swp_entry_t entry; > > + VM_BUG_ON(!PageSwapCache(page)); > > + entry.val = page_private(page); > >

Re: [RFC PATCH] LTTng instrumentation mm (updated)

2007-11-30 Thread Dave Hansen
On Fri, 2007-11-30 at 11:11 -0500, Mathieu Desnoyers wrote: > +static inline swp_entry_t page_swp_entry(struct page *page) > +{ > + swp_entry_t entry; > + VM_BUG_ON(!PageSwapCache(page)); > + entry.val = page_private(page); > + return entry; > +} This probably needs to be i

[RFC PATCH] LTTng instrumentation mm (updated)

2007-11-30 Thread Mathieu Desnoyers
LTTng instrumentation mm Memory management core events. Changelog: - Use page_to_pfn for swap out instrumentation, wait_on_page_bit, do_swap_page, page alloc/free. - add missing free_hot_cold_page instrumentation. - add hugetlb page_alloc page_free instrumentation. - Add write_access to mm faul