Re: [alsa-devel] [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-28 Thread Takashi Iwai
On Mon, 28 Jan 2019 14:31:23 +0100, Jaroslav Kysela wrote: > > Dne 25.1.2019 v 19:25 Mark Brown napsal(a): > > On Fri, Jan 25, 2019 at 02:19:22PM +0100, Takashi Iwai wrote: > >> Leo Yan wrote: > > > >>> If we directly use the device node /dev/snd/ as file descriptor, even > >>> though we specify

Re: [alsa-devel] [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-28 Thread Jaroslav Kysela
Dne 25.1.2019 v 19:25 Mark Brown napsal(a): > On Fri, Jan 25, 2019 at 02:19:22PM +0100, Takashi Iwai wrote: >> Leo Yan wrote: > >>> If we directly use the device node /dev/snd/ as file descriptor, even >>> though we specify flag O_EXCL when open it, but it still is not an >>> anon inode file descr

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-27 Thread Baolin Wang
On Fri, 25 Jan 2019 at 21:04, Takashi Iwai wrote: > > > > > > Erm, obviously it's not enough. Each attach / detach needs to manage > > > the refcount, too, for covering the cases above. It can re-use the > > > PCM mmap_refount, though. > > > > But we've used the DMA buffer file's refcounting to

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-27 Thread Baolin Wang
On Fri, 25 Jan 2019 at 21:03, Takashi Iwai wrote: > > On Fri, 25 Jan 2019 12:11:43 +0100, > Baolin Wang wrote: > > > > Hi Takashi, > > On Fri, 25 Jan 2019 at 18:10, Takashi Iwai wrote: > > > > > > On Fri, 25 Jan 2019 10:25:37 +0100, > > > Baolin Wang wrote: > > > > > > > > Hi Jaroslav, > > > > On

Re: [alsa-devel] [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Mark Brown
On Fri, Jan 25, 2019 at 02:19:22PM +0100, Takashi Iwai wrote: > Leo Yan wrote: > > If we directly use the device node /dev/snd/ as file descriptor, even > > though we specify flag O_EXCL when open it, but it still is not an > > anon inode file descriptor. Thus this is not safe enough and will be

Re: [alsa-devel] [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Takashi Iwai
On Wed, 23 Jan 2019 13:46:58 +0100, Leo Yan wrote: > > Hi all, > > On Wed, Jan 23, 2019 at 12:58:51PM +0100, Takashi Iwai wrote: > > On Tue, 22 Jan 2019 21:25:35 +0100, > > Mark Brown wrote: > > > > > > On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: > > > > Dne 21.1.2019 v 13:4

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Takashi Iwai
On Fri, 25 Jan 2019 12:24:29 +0100, Baolin Wang wrote: > > On Fri, 25 Jan 2019 at 18:20, Takashi Iwai wrote: > > > > On Fri, 25 Jan 2019 11:10:25 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 25 Jan 2019 10:25:37 +0100, > > > Baolin Wang wrote: > > > > > > > > Hi Jaroslav, > > > > On Thu, 24

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Takashi Iwai
On Fri, 25 Jan 2019 12:11:43 +0100, Baolin Wang wrote: > > Hi Takashi, > On Fri, 25 Jan 2019 at 18:10, Takashi Iwai wrote: > > > > On Fri, 25 Jan 2019 10:25:37 +0100, > > Baolin Wang wrote: > > > > > > Hi Jaroslav, > > > On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > > > > > > > Dne 23

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Baolin Wang
On Fri, 25 Jan 2019 at 18:20, Takashi Iwai wrote: > > On Fri, 25 Jan 2019 11:10:25 +0100, > Takashi Iwai wrote: > > > > On Fri, 25 Jan 2019 10:25:37 +0100, > > Baolin Wang wrote: > > > > > > Hi Jaroslav, > > > On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > > > > > > > Dne 23.1.2019 v 13

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Baolin Wang
Hi Takashi, On Fri, 25 Jan 2019 at 18:10, Takashi Iwai wrote: > > On Fri, 25 Jan 2019 10:25:37 +0100, > Baolin Wang wrote: > > > > Hi Jaroslav, > > On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > > > > > Dne 23.1.2019 v 13:46 Leo Yan napsal(a): > > > > Hi all, > > > > > > > > On Wed, Jan

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Takashi Iwai
On Fri, 25 Jan 2019 11:10:25 +0100, Takashi Iwai wrote: > > On Fri, 25 Jan 2019 10:25:37 +0100, > Baolin Wang wrote: > > > > Hi Jaroslav, > > On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > > > > > Dne 23.1.2019 v 13:46 Leo Yan napsal(a): > > > > Hi all, > > > > > > > > On Wed, Jan 23,

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Takashi Iwai
On Fri, 25 Jan 2019 10:25:37 +0100, Baolin Wang wrote: > > Hi Jaroslav, > On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > > > Dne 23.1.2019 v 13:46 Leo Yan napsal(a): > > > Hi all, > > > > > > On Wed, Jan 23, 2019 at 12:58:51PM +0100, Takashi Iwai wrote: > > >> On Tue, 22 Jan 2019 21:25:

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-25 Thread Baolin Wang
Hi Jaroslav, On Thu, 24 Jan 2019 at 21:43, Jaroslav Kysela wrote: > > Dne 23.1.2019 v 13:46 Leo Yan napsal(a): > > Hi all, > > > > On Wed, Jan 23, 2019 at 12:58:51PM +0100, Takashi Iwai wrote: > >> On Tue, 22 Jan 2019 21:25:35 +0100, > >> Mark Brown wrote: > >>> > >>> On Mon, Jan 21, 2019 at 03:15

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-24 Thread Mark Brown
On Thu, Jan 24, 2019 at 02:43:02PM +0100, Jaroslav Kysela wrote: > If I look to the dma_buf_fd() implementation: > fd = get_unused_fd_flags(flags); > fd_install(fd, dmabuf->file); > .. what if we just add one new ioctl to the ALSA's PCM API which will > return a new anonymous inode descripto

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-24 Thread Jaroslav Kysela
Dne 23.1.2019 v 13:46 Leo Yan napsal(a): > Hi all, > > On Wed, Jan 23, 2019 at 12:58:51PM +0100, Takashi Iwai wrote: >> On Tue, 22 Jan 2019 21:25:35 +0100, >> Mark Brown wrote: >>> >>> On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: Dne 21.1.2019 v 13:40 Mark Brown napsal(a):

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-23 Thread Leo Yan
Hi all, On Wed, Jan 23, 2019 at 12:58:51PM +0100, Takashi Iwai wrote: > On Tue, 22 Jan 2019 21:25:35 +0100, > Mark Brown wrote: > > > > On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: > > > Dne 21.1.2019 v 13:40 Mark Brown napsal(a): > > > > > > It was the bit about adding more

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-23 Thread Takashi Iwai
On Tue, 22 Jan 2019 21:25:35 +0100, Mark Brown wrote: > > On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: > > Dne 21.1.2019 v 13:40 Mark Brown napsal(a): > > > > It was the bit about adding more extended permission control that I was > > > worried about there, not the initial O_A

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-22 Thread Mark Brown
On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: > Dne 21.1.2019 v 13:40 Mark Brown napsal(a): > > It was the bit about adding more extended permission control that I was > > worried about there, not the initial O_APPEND bit. Indeed the O_APPEND > > bit sounds like it might also w

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-21 Thread Jaroslav Kysela
Dne 21.1.2019 v 13:40 Mark Brown napsal(a): > On Fri, Jan 18, 2019 at 08:39:32PM +0100, Takashi Iwai wrote: >> Mark Brown wrote: > multiple tasks). I would probably go in this way and add more extended permission control for the PCM device, so permissions can be restricted for the p

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-21 Thread Mark Brown
On Fri, Jan 18, 2019 at 08:39:32PM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > > multiple tasks). I would probably go in this way and add more extended > > > permission control for the PCM device, so permissions can be restricted > > > for the passed descriptor to the producer or the consum

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-18 Thread Takashi Iwai
On Fri, 18 Jan 2019 20:08:05 +0100, Mark Brown wrote: > > On Fri, Jan 18, 2019 at 10:35:44AM +0100, Jaroslav Kysela wrote: > > > the tinyalsa implementation does not show much - it's equal to the > > standard mmap access for the PCM devices. Even considering the Mark's > > text, there must be a

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-18 Thread Mark Brown
On Fri, Jan 18, 2019 at 10:35:44AM +0100, Jaroslav Kysela wrote: > the tinyalsa implementation does not show much - it's equal to the > standard mmap access for the PCM devices. Even considering the Mark's > text, there must be an arbiter (sound server) which communicates with > the producer or

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-18 Thread Jaroslav Kysela
Dne 18.1.2019 v 05:55 Baolin Wang napsal(a): > This patch adds dma share buffer support, which allows a dma-buf to be shared > between processes by passing file descriptors between them, allowing multiple > processes to cooperate in filling the DMA buffer used by the audio hardware > without the ne

[RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-17 Thread Baolin Wang
This patch adds dma share buffer support, which allows a dma-buf to be shared between processes by passing file descriptors between them, allowing multiple processes to cooperate in filling the DMA buffer used by the audio hardware without the need to copy data around. This reduces both latency and