Re: [RFC 7/7] net: don't check for active hrtimer after adding it

2014-07-09 Thread Viresh Kumar
On 9 July 2014 16:14, Viresh Kumar wrote: > Yeah, it looks like we can get rid of this. Also, > > } while (t.task && pkt_dev->running && !signal_pending(current)); > > is present in the closing "}" of do-while loop and probably we > don't need to check t.task here as well. Actually No. t.

Re: [RFC 7/7] net: don't check for active hrtimer after adding it

2014-07-09 Thread Chris Redpath
On 09/07/14 11:44, Viresh Kumar wrote: Hi Chris, On 9 July 2014 16:02, Chris Redpath wrote: diff --git a/net/core/pktgen.c b/net/core/pktgen.c index fc17a9d..f911acd 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2186,8 +2186,6 @@ static void spin(struct pktgen_dev *pkt_dev, ktime

Re: [RFC 7/7] net: don't check for active hrtimer after adding it

2014-07-09 Thread Viresh Kumar
Hi Chris, On 9 July 2014 16:02, Chris Redpath wrote: >> diff --git a/net/core/pktgen.c b/net/core/pktgen.c >> index fc17a9d..f911acd 100644 >> --- a/net/core/pktgen.c >> +++ b/net/core/pktgen.c >> @@ -2186,8 +2186,6 @@ static void spin(struct pktgen_dev *pkt_dev, ktime_t >> spin_until) >>

Re: [RFC 7/7] net: don't check for active hrtimer after adding it

2014-07-09 Thread Chris Redpath
Hi Viresh, On 09/07/14 07:55, Viresh Kumar wrote: hrtimer_start*() family never fails to enqueue a hrtimer to a clock-base. The only special case is when the hrtimer was in past. If it is getting enqueued to local CPUs's clock-base, we raise a softirq and exit, else we handle that on next interr

[RFC 7/7] net: don't check for active hrtimer after adding it

2014-07-08 Thread Viresh Kumar
hrtimer_start*() family never fails to enqueue a hrtimer to a clock-base. The only special case is when the hrtimer was in past. If it is getting enqueued to local CPUs's clock-base, we raise a softirq and exit, else we handle that on next interrupt on remote CPU. At several places in the kernel,