Re: [RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-11-07 Thread Pavel Machek
Hi! > So in (error) case of ! aux_dev->codec_of_node && ! aux_dev->codec_name > we match first possible codec? > > Given code similarity between this and the one above, should there be > helper function that does the comparison (or even walks the list)? Something like this? soc_probe_aux_dev n

Re: [RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-11-06 Thread Pavel Machek
Hi! > This patch adds support for specifying auxiliary codecs and > codec configuration via device tree phandles. > > This change adds new fields to snd_soc_aux_dev and snd_soc_codec_conf > and adds support for the changes to SoC core methods. > > Signed-off-by: Sebastian Reichel > --- > inclu

Re: [RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-10-28 Thread Mark Brown
On Mon, Oct 28, 2013 at 06:53:42PM +0100, Sebastian Reichel wrote: > On Mon, Oct 28, 2013 at 09:37:21AM -0700, Mark Brown wrote: > > This doesn't apply against current git, please check and resend. > Can you give me a git url to rebase against? I used current git > master from torvalds. From MAI

Re: [RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-10-28 Thread Sebastian Reichel
On Mon, Oct 28, 2013 at 09:37:21AM -0700, Mark Brown wrote: > On Sun, Oct 27, 2013 at 10:24:45PM +0100, Sebastian Reichel wrote: > > This patch adds support for specifying auxiliary codecs and > > codec configuration via device tree phandles. > > This doesn't apply against current git, please chec

Re: [RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-10-28 Thread Mark Brown
On Sun, Oct 27, 2013 at 10:24:45PM +0100, Sebastian Reichel wrote: > This patch adds support for specifying auxiliary codecs and > codec configuration via device tree phandles. This doesn't apply against current git, please check and resend. Please also consider your CC list more carefully, there'

[RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-10-27 Thread Sebastian Reichel
This patch adds support for specifying auxiliary codecs and codec configuration via device tree phandles. This change adds new fields to snd_soc_aux_dev and snd_soc_codec_conf and adds support for the changes to SoC core methods. Signed-off-by: Sebastian Reichel --- include/sound/soc.h | 13 ++