Re: [RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Tejun Heo
Hello, On Thu, Oct 25, 2012 at 10:41:57AM -0700, Brian Norris wrote: > Hmm, I guess that makes more sense. I was using the ahci_platform > ahci_platform_data->exit() function. Would it be safe to call the > platform init()/exit() functions as part of a > ata_port_operations.host_{start,stop}() hoo

Re: [RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Brian Norris
On Thu, Oct 25, 2012 at 10:25 AM, Tejun Heo wrote: > On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote: >> devres functions are intended for simplified cleanup of memory and other >> software resources on device exit, not for hardware shutdown sequences. >> In addition, inducing hardwar

Re: [RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Tejun Heo
On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote: > devres functions are intended for simplified cleanup of memory and other > software resources on device exit, not for hardware shutdown sequences. > In addition, inducing hardware activity at device removal hamstrings > some drivers (p

[RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Brian Norris
devres functions are intended for simplified cleanup of memory and other software resources on device exit, not for hardware shutdown sequences. In addition, inducing hardware activity at device removal hamstrings some drivers (particularly ahci_platform) so that they cannot totally power off their