Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-09 Thread Krzysztof Kozlowski
On Mon, Oct 09, 2017 at 08:46:48PM +0530, Anand Moon wrote: > hi Krzysztof, > > On 9 October 2017 at 02:37, Anand Moon wrote: > > Hi Krzysztof, > > > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > >> On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > >>> Hi Krzysztof, > >>

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-09 Thread Krzysztof Kozlowski
On Mon, Oct 09, 2017 at 02:37:14AM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > >> > On Fri

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-09 Thread Anand Moon
hi Krzysztof, On 9 October 2017 at 02:37, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: >> On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: >>> > On Fri, Oc

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> >> remove the disable and en

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Krzysztof Kozlowski
On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > >> remove the disable and enable of phy clk. > >> phy clk is needed to tune the phy controller. > > > > D

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> remove the disable and enable of phy clk. >> phy clk is needed to tune the phy controller. > > Drivers should in general enable and disable the clocks they use. Just > like

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-05 Thread Krzysztof Kozlowski
On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > remove the disable and enable of phy clk. > phy clk is needed to tune the phy controller. Drivers should in general enable and disable the clocks they use. Just like in patch #1 please describe why you are doing this, what kind of problem are yo

[RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-05 Thread Anand Moon
remove the disable and enable of phy clk. phy clk is needed to tune the phy controller. Before: mout_usbd300 112400 0 0 dout_usbd300 002400 0 0 sclk_usbd300