Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-12-04 Thread Michal Hocko
On Thu 04-12-14 17:56:01, Michal Hocko wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 1d55ab12792f..032be9d2a239 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -408,7 +408,7 @@ static void dump_header(struct task_struct *p, gfp_t > gfp_mask, int order, > * Number of OOM vic

Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-12-04 Thread Michal Hocko
On Thu 04-12-14 09:44:54, Tejun Heo wrote: > On Thu, Dec 04, 2014 at 03:16:23PM +0100, Michal Hocko wrote: > > > A delta but shouldn't it be pr_cont()? > > > > kernel/power/process.c doesn't use pr_* so I've stayed with what the > > rest of the file is using. I can add a patch which transforms all

Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-12-04 Thread Tejun Heo
On Thu, Dec 04, 2014 at 03:16:23PM +0100, Michal Hocko wrote: > > A delta but shouldn't it be pr_cont()? > > kernel/power/process.c doesn't use pr_* so I've stayed with what the > rest of the file is using. I can add a patch which transforms all of > them. The console output becomes wrong when pr

Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-12-04 Thread Michal Hocko
On Tue 02-12-14 17:08:04, Tejun Heo wrote: > Hello, sorry about the delay. Was on vacation. > > Generally looks good to me. Some comments below. > > > @@ -355,8 +355,10 @@ static struct sysrq_key_op sysrq_term_op = { > > > > static void moom_callback(struct work_struct *ignored) > > { > > -

Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-12-02 Thread Tejun Heo
Hello, sorry about the delay. Was on vacation. Generally looks good to me. Some comments below. > @@ -355,8 +355,10 @@ static struct sysrq_key_op sysrq_term_op = { > > static void moom_callback(struct work_struct *ignored) > { > - out_of_memory(node_zonelist(first_memory_node, GFP_KERNE

Re: [RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-11-26 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 10:10:06 PM Michal Hocko wrote: > 5695be142e20 (OOM, PM: OOM killed task shouldn't escape PM suspend) > has left a race window when OOM killer manages to note_oom_kill after > freeze_processes checks the counter. The race window is quite small and > really unlikely and

[RFC 2/2] OOM, PM: make OOM detection in the freezer path raceless

2014-11-18 Thread Michal Hocko
5695be142e20 (OOM, PM: OOM killed task shouldn't escape PM suspend) has left a race window when OOM killer manages to note_oom_kill after freeze_processes checks the counter. The race window is quite small and really unlikely and partial solution deemed sufficient at the time of submission. Tejun