Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Mike Galbraith
On Thu, 2018-02-15 at 10:07 -0800, Rohit Jain wrote: > > > Rohit is running more tests with a patch that deletes > > sysctl_sched_migration_cost from idle_balance, and for his patch but > > with the 5000 usec mistake corrected back to 500 usec. So far both > > give improvements over the baseline,

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Mike Galbraith
On Thu, 2018-02-15 at 13:21 -0500, Steven Sistare wrote: > On 2/15/2018 1:07 PM, Mike Galbraith wrote: > > >> Can you provide more details on the sysbench oltp test that motivated you > >> to add sysctl_sched_migration_cost to idle_balance, so Rohit can re-test > >> it? > > > > The problem at th

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Steven Sistare
On 2/15/2018 1:07 PM, Mike Galbraith wrote: > On Thu, 2018-02-15 at 11:35 -0500, Steven Sistare wrote: >> On 2/10/2018 1:37 AM, Mike Galbraith wrote: >>> On Fri, 2018-02-09 at 11:08 -0500, Steven Sistare wrote: >> @@ -8804,7 +8803,8 @@ static int idle_balance(struct rq *this_rq, struct >>

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Mike Galbraith
On Thu, 2018-02-15 at 11:35 -0500, Steven Sistare wrote: > On 2/10/2018 1:37 AM, Mike Galbraith wrote: > > On Fri, 2018-02-09 at 11:08 -0500, Steven Sistare wrote: > @@ -8804,7 +8803,8 @@ static int idle_balance(struct rq *this_rq, struct > rq_flags *rf) > if (!(sd-

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Rohit Jain
On 02/15/2018 08:35 AM, Steven Sistare wrote: On 2/10/2018 1:37 AM, Mike Galbraith wrote: On Fri, 2018-02-09 at 11:08 -0500, Steven Sistare wrote: @@ -8804,7 +8803,8 @@ static int idle_balance(struct rq *this_rq, struct rq_flags *rf) if (!(sd->flags & SD_LOAD_BALANCE))

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-15 Thread Steven Sistare
On 2/10/2018 1:37 AM, Mike Galbraith wrote: > On Fri, 2018-02-09 at 11:08 -0500, Steven Sistare wrote: @@ -8804,7 +8803,8 @@ static int idle_balance(struct rq *this_rq, struct rq_flags *rf) if (!(sd->flags & SD_LOAD_BALANCE)) continue;

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-09 Thread Mike Galbraith
On Fri, 2018-02-09 at 11:08 -0500, Steven Sistare wrote: > >> @@ -8804,7 +8803,8 @@ static int idle_balance(struct rq *this_rq, struct > >> rq_flags *rf) > >>if (!(sd->flags & SD_LOAD_BALANCE)) > >>continue; > >> > >> - if (this_rq->avg_idle < curr_cost +

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-09 Thread Steven Sistare
On 2/8/2018 10:42 PM, Mike Galbraith wrote: > On Thu, 2018-02-08 at 14:19 -0800, Rohit Jain wrote: >> This patch makes idle_balance more dynamic as the sched_migration_cost >> is now accounted on a sched_domain level. This in turn is done in >> sd_init when we know what the topology relationships a

Re: [RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-08 Thread Mike Galbraith
On Thu, 2018-02-08 at 14:19 -0800, Rohit Jain wrote: > This patch makes idle_balance more dynamic as the sched_migration_cost > is now accounted on a sched_domain level. This in turn is done in > sd_init when we know what the topology relationships are. > > For introduction sakes cost of migration

[RFC 1/2] sched: reduce migration cost between faster caches for idle_balance

2018-02-08 Thread Rohit Jain
This patch makes idle_balance more dynamic as the sched_migration_cost is now accounted on a sched_domain level. This in turn is done in sd_init when we know what the topology relationships are. For introduction sakes cost of migration within the same core is set as 0, across cores is 50 usec and