Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread Jon Mason
On Mon, Jul 16, 2012 at 03:27:48PM -0400, chetan loke wrote: > On Mon, Jul 16, 2012 at 2:38 PM, Jon Mason wrote: > > On Mon, Jul 16, 2012 at 12:49:39PM -0400, chetan loke wrote: > > > > >> Is it ok to rename the following vars for convenience sake? > >> > >> > + struct list_head txq;

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
On Mon, Jul 16, 2012 at 2:38 PM, Jon Mason wrote: > On Mon, Jul 16, 2012 at 12:49:39PM -0400, chetan loke wrote: >> Is it ok to rename the following vars for convenience sake? >> >> > + struct list_head txq; >> tx_pend_q - (pending_queue) or tx_out_q - (outstanding_queue) - or >> pick

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread Jon Mason
On Mon, Jul 16, 2012 at 12:49:39PM -0400, chetan loke wrote: > Hi Jon, > > On Fri, Jul 13, 2012 at 5:44 PM, Jon Mason wrote: > > Just a few minor comments/questions: > > > > > +struct ntb_transport_qp { > > + struct ntb_device *ndev; > > + > > + bool client_ready; > > +

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread Greg KH
On Mon, Jul 16, 2012 at 10:55:06AM -0700, Jon Mason wrote: > On Sun, Jul 15, 2012 at 05:19:21PM -0700, Greg KH wrote: > > On Sun, Jul 15, 2012 at 04:55:48PM -0700, Jon Mason wrote: > > > On Sat, Jul 14, 2012 at 10:10:15AM -0700, Greg KH wrote: > > > > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon M

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
Jon, On Fri, Jul 13, 2012 at 5:44 PM, Jon Mason wrote: .. > +/** > + * ntb_ring_sdb() - Set the doorbell on the secondary/external side > + * @ndev: pointer to ntb_device instance > + * @db: doorbell to ring > + * > + * This function allows triggering of a doorbell on the secondary/

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread Jon Mason
On Sun, Jul 15, 2012 at 05:19:21PM -0700, Greg KH wrote: > On Sun, Jul 15, 2012 at 04:55:48PM -0700, Jon Mason wrote: > > On Sat, Jul 14, 2012 at 10:10:15AM -0700, Greg KH wrote: > > > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > > > > +static int max_num_cbs = 2; > > > > +module_pa

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
Hi Jon, On Fri, Jul 13, 2012 at 5:44 PM, Jon Mason wrote: Just a few minor comments/questions: > +struct ntb_transport_qp { > + struct ntb_device *ndev; > + > + bool client_ready; > + bool qp_link; > + u8 qp_num; /* Only 64 QP's are allowed. 0-63 */ > + > +

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-15 Thread Greg KH
On Sun, Jul 15, 2012 at 04:55:48PM -0700, Jon Mason wrote: > On Sat, Jul 14, 2012 at 10:10:15AM -0700, Greg KH wrote: > > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > > > +static int max_num_cbs = 2; > > > +module_param(max_num_cbs, uint, 0644); > > > +MODULE_PARM_DESC(max_num_cbs,

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-15 Thread Jon Mason
On Sat, Jul 14, 2012 at 10:10:15AM -0700, Greg KH wrote: > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > > +static int max_num_cbs = 2; > > +module_param(max_num_cbs, uint, 0644); > > +MODULE_PARM_DESC(max_num_cbs, "Maximum number of NTB transport > > connections"); > > + > > +stati

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-15 Thread Greg KH
On Sun, Jul 15, 2012 at 04:50:41PM -0700, Jon Mason wrote: > On Sat, Jul 14, 2012 at 10:04:11AM -0700, Greg KH wrote: > > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > > > The NTB device driver is needed to configure these memory windows, > > > doorbell, and > > > scratch-pad regist

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-15 Thread Jon Mason
On Sat, Jul 14, 2012 at 10:04:11AM -0700, Greg KH wrote: > On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > > The NTB device driver is needed to configure these memory windows, > > doorbell, and > > scratch-pad registers as well as use them in such a way as they can be > > turned > >

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-15 Thread David Hagood
Have you looked at any of the work that the PXI group has done on NTB support within PXI? http://www.ni.com/white-paper/12523/en I was on that working group, and one of the first capabilities I suggested for it was IP over NTB - I was going to implement this at my employer, but the project took a

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-14 Thread Greg KH
On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > +static int max_num_cbs = 2; > +module_param(max_num_cbs, uint, 0644); > +MODULE_PARM_DESC(max_num_cbs, "Maximum number of NTB transport connections"); > + > +static bool no_msix; > +module_param(no_msix, bool, 0644); > +MODULE_PARM_DESC(

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-14 Thread Greg KH
On Fri, Jul 13, 2012 at 02:44:59PM -0700, Jon Mason wrote: > The NTB device driver is needed to configure these memory windows, doorbell, > and > scratch-pad registers as well as use them in such a way as they can be turned > into a viable communication channel to the remote system. ntb_hw.[ch] >

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-13 Thread Jon Mason
On Fri, Jul 13, 2012 at 05:13:44PM -0700, Stephen Hemminger wrote: > On Fri, 13 Jul 2012 14:44:59 -0700 > Jon Mason wrote: > > > A PCI-Express non-transparent bridge (NTB) is a point-to-point PCIe bus > > connecting 2 systems, providing electrical isolation between the two > > subsystems. > > A

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-13 Thread Stephen Hemminger
On Fri, 13 Jul 2012 14:44:59 -0700 Jon Mason wrote: > A PCI-Express non-transparent bridge (NTB) is a point-to-point PCIe bus > connecting 2 systems, providing electrical isolation between the two > subsystems. > A non-transparent bridge is functionally similar to a transparent bridge > except

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-13 Thread Stephen Hemminger
On Fri, 13 Jul 2012 14:44:59 -0700 Jon Mason wrote: > A PCI-Express non-transparent bridge (NTB) is a point-to-point PCIe bus > connecting 2 systems, providing electrical isolation between the two > subsystems. > A non-transparent bridge is functionally similar to a transparent bridge > except